Expose jobrunner metrics - #976
Open
sbidoul wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @guewen, |
sbidoul
force-pushed
the
19.0-metrics-sbi
branch
from
August 31, 2026 17:58
9d47e26 to
4d3a77c
Compare
sbidoul
commented
Aug 31, 2026
| self._metrics_labels = { | ||
| "channel": self.fullname, | ||
| "root": not bool(self.parent), | ||
| "leaf": not bool(self.children), |
Member
Author
There was a problem hiding this comment.
Maybe move this to configure? Because the leaf label is probably not correct if/when children are added after the parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first draft towards #965
This turns out to be fairly simple. A few things worth noting:
prometheus-clientexternal library. It's currently required even if the metrics server is not configured. This could be improved by mocking the lib and making it mandatory only for users enabling the metrics server. Or make it a required dependency (which is my preference, for simplicity).Test by setting
ODOO_QUEUE_JOB_METRICS_PORT=8080before running Odoo thenwatch curl -s http://localhost:8080.Assisted-By: Pamina (my cat)