Skip to content

Refactor Calendar Domain - #4728

Merged
wavehassman merged 5 commits into
developfrom
refactor-calendar-domain
Nov 14, 2026
Merged

wavehassman merged 5 commits into
developfrom
refactor-calendar-domain

Conversation

@chpy04

@chpy04 chpy04 commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Refactor calendar events domain to use slim models

Related to https://nerdocs.atlassian.net/wiki/spaces/NER/pages/2231697435/Root+Cause+Analysis+EC2+OOMs

Models:

  • BaseEvent: primitives, userCreated, teamType, scheduledTimes
  • CalendarEvent: calendar grid and Your Events / Review Bookings tables. Member counts replace member lists
  • EventDetail: event popup, edit modal, availability page. isCurrentUserOnEvent is computed in the DB
  • UpcomingEvent: calendar sidebar and lead home "Upcoming Design Reviews"
  • EventConflict, GuestEventInstance, UserEventAttendance

Endpoints

  • Added: GET /events/my-conflicts, GET /events/reviews, GET /events/upcoming, GET /events/attendance
  • Removed: GET /events, GET /event-members/:id, GET /event/:id/conflict
  • POST /events/filter: filters by time range
  • POST /events-paginated: takes a direction and runs one query; the cursor is (startTime, scheduleSlotId)
  • ICS feed: only slots from the last 6 months onward
  • Event mutations return 204; create returns { eventId }

Frontend

  • The event popup and edit modal load EventDetail when opened instead of in initial page load
  • Conflict banners load in the background instead of blocking the calendar page
  • Your Events and Review Bookings load only when their tab is open

Bug fixes

  • Add org check on GET /events and POST /events/filter
  • uploadDocument permission check was always false
  • scheduleEvent modified slots and availabilities before checking permission
  • editEvent team type validation never failed (findMany)
  • Guest events pagination repeated or skipped items

@wavehassman
wavehassman self-requested a review November 13, 2026 14:51

@wavehassman wavehassman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BANG

@wavehassman
wavehassman merged commit 0dc62c8 into develop Nov 14, 2026
4 checks passed
@wavehassman
wavehassman deleted the refactor-calendar-domain branch November 14, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants