Repository navigation
#4633 konstantinos zeimbekis countdown admin tools edit - #4673
Open
kostazeimbek wants to merge 16 commits into
Open
kostazeimbek wants to merge 16 commits into
kostazeimbek wants to merge 16 commits into
Conversation
…onstantinosZeimbekis-Countdown-Admin-Tools-Edit Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-Countdown-Admin-Tools-Edit
cielbellerose
requested changes
Nov 5, 2026
cielbellerose
left a comment
cielbellerose
left a comment
Contributor
There was a problem hiding this comment.
This looks great!! just have one small ask
Up to you if you want to implement the primary/secondary update in the modal (simplest) or as an inline dropdown (good reference for that kind of inline editing would be the table on a project's bom tab)
…-Countdown-Admin-Tools-Edit Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… of github-other:Northeastern-Electric-Racing/FinishLine into #4633-KonstantinosZeimbekis-Countdown-Admin-Tools-Edit
cielbellerose
self-requested a review
November 6, 2026 20:48
cielbellerose
approved these changes
Nov 6, 2026
| handleClose(); | ||
| } catch (error: unknown) { | ||
| if (error instanceof Error) { | ||
| toast.error(error.message); |
Contributor
There was a problem hiding this comment.
we already toast the error in the hook so we can remove this toast.error
wavehassman
requested changes
Nov 9, 2026
| * This file is part of NER's FinishLine and licensed under GNU AGPLv3. | ||
| * See the LICENSE file in the repository root folder for details. | ||
| */ | ||
|
|
Contributor
There was a problem hiding this comment.
you should reuse CountdownFormModal
| *@returns this returns something that is resolved to the update of the countdown object | ||
| */ | ||
| export const editBayDashboardCountdown = ( | ||
| countdownId: string, |
Contributor
There was a problem hiding this comment.
you could use BayDashboardCountdownCreateArgs here too I think or slightly change them around
Contributor
Author
There was a problem hiding this comment.
I think i finished with every comment being resolved if you want to take a look at it.
…-Countdown-Admin-Tools-Edit
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I created the edit button for the bay dashboard that only allows admins to edit/ tamper with it.
Notes
For starters, I used AI for guidance, as stated before. Nothing was written by it, though. I merged with #4453 so I could use a certain file that they had in their branch, so I would suggest merging that first. Apologies if this was a nuisance. #4453 made isPrimary required on the edit endpoint. There was a bug whenever I tried to change anything on the bay dashboard, so I fixed it by allowing edits countdown to keep the current isPrimary without changing it, and there's no checkbox in the edit modal. Finally, Edit uses the same dateToMidnightUTC / dbDateToLocalDate date thing that create uses, so dates don't shift by a day
Bug elsewhere
I'll keep this section short since I found this accidentally. When I was trying to test the code I wrote, I used a head by accident and went to the calendar to see if it works. And it didn't. When I tried to select anything that didn't have a Zoom link, it threw an error saying, "Event Type requires Event type does not allow a Zoom link"
Test Cases
I tested everything manually based on this set
*if I can see the edit icon
*if I can click on the icon
*if I can edit name and dates
*And any errors/edge cases that could throw errors or pass
Screenshots
If you made UI changes you must post a screenshot of the whole page for each change in 1) a normal sized window and 2) the smallest possible window
To Do
N/A
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4633