Skip to content

site: balance styling against nixos branding identity - #1279

Merged
hsjobeki merged 6 commits into
NixOS:masterfrom
hsjobeki:colors
Sep 5, 2026
Merged

site: balance styling against nixos branding identity #1279
hsjobeki merged 6 commits into
NixOS:masterfrom
hsjobeki:colors

Conversation

@hsjobeki

Copy link
Copy Markdown
Collaborator

@hsjobeki
hsjobeki requested a review from a team as a code owner August 29, 2026 15:41

@trespaul trespaul left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon and mainsail-10 is undefined (or mainsail-05 is unused).

Making light mode higher contrast is fair, I'm probably biased towards making it less bright. But dark mode is also now lower-constrast. I prefer the slightly higher contrast — what's your reasoning?

But we don't have to bikeshed about the colours (since they'll probably change anyway as we combine design efforts with the marketing team). so I'm fine accepting these colours.

Comment thread site/src/styles/global.css Outdated
--color-grey-96: oklch(0.17 0 0); /* #0f0f0f */

/* More colors for dark mode */
--color-steel-95: oklch(0.21 0.008 274.5) /* #17181c; */

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semicolon!

Comment thread site/src/layouts/Base.astro Outdated
bg-grey-05 text-grey-95 dark:bg-grey-95 dark:text-grey-05"
<body
class="flex flex-col min-h-dvh gap-y-8
bg-white text-black dark:bg-steel-95 dark:text-mainsail-05"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainsail-10?

@hsjobeki

hsjobeki commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator Author

I have gone ahead now with this PR and aligned what we discussed during the documentation office hours.

See the individual commits

@hsjobeki
hsjobeki force-pushed the colors branch 2 times, most recently from 4d4911c to ec4c8de Compare September 5, 2026 10:31
Match nixos.org, except Inter replaces Roboto Flex. Route159 has
no npm package; vendored from nixos-homepage.
Init script is inline in head so the stored choice applies before
first paint.
The colored borders and tinted fills competed with the content.
@hsjobeki
hsjobeki force-pushed the colors branch 2 times, most recently from 65557bd to acaa513 Compare September 5, 2026 10:42
@hsjobeki hsjobeki changed the title site: adjust surface colors for light and dark mode site: align styling with brand identity Sep 5, 2026
@hsjobeki hsjobeki changed the title site: align styling with brand identity site: balance styling with brand identity Sep 5, 2026
@hsjobeki hsjobeki changed the title site: balance styling with brand identity site: balance styling with against identity Sep 5, 2026
@hsjobeki hsjobeki changed the title site: balance styling with against identity site: balance styling against nixos branding identity Sep 5, 2026
@hsjobeki
hsjobeki merged commit 6b382b2 into NixOS:master Sep 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants