Repository navigation
feat!: target .NET 10 and update dependencies - #218
Merged
Merged
Conversation
Source files, the solution and README.md were saved as UTF-16 LE, so git treated them as binary (no diffs) and the README packed into the NuGet packages was UTF-16. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Target net10.0 only (drop net8.0/net9.0, both end of support since 2026-11-10) - Central Package Management; shared NuGet metadata in src/Directory.Build.props - NuGet Audit as errors, global.json, .editorconfig, dependabot - Microsoft.Extensions.* 10.0.15, Sodium.Core 1.4.1 - Demo: drop Microsoft.VisualStudio.Web.CodeGeneration.Design (source of all vulnerable transitive packages); Docker build context is now the repo root - Tests: xunit.v3 on Microsoft.Testing.Platform, AwesomeAssertions instead of FluentAssertions 8 (commercial license), remove unused Moq - Add stored-hash compatibility tests (Argon2id, scrypt, bcrypt 2a/2b/2y, ASP.NET Identity v2/v3) generated with 7.1.2 - CI: actions v5, publish now runs the tests, vulnerable package check, pack/push only on new release, symbols are pushed, assembly version follows release - Fix RepositoryBranch (master) and ContinuousIntegrationBuild only on CI BREAKING CHANGE: packages now target .NET 10 only. Stay on 7.x for .NET 8/9. Stored hashes from 7.x remain valid. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes Security.PasswordHasher for .NET 10 (LTS). .NET 8 and .NET 9 reached end of support on 2026-11-10.
Review the commits separately:
chore: convert UTF-16 files to UTF-8: 20 files (sources, solution, README) were UTF-16 LE. Git treated them as binary, so there were no diffs, and the README packed into the NuGet packages was UTF-16. Encoding change only.feat!: target .NET 10 and update dependencies: the actual upgrade.Breaking change (release 8.0.0)
net10.0only. Consumers on .NET 8/9 stay on 7.x.Dependencies
Directory.Packages.props). The NuGet metadata that was repeated in four csproj files is now insrc/Directory.Build.props.Microsoft.VisualStudio.Web.CodeGeneration.Design. It was the source of every vulnerable transitive package (Microsoft.Build.Tasks.Core high, System.Security.Cryptography.Pkcs high, NuGet.* low). The Docker build context is now the repository root, because CPM files live there.global.json,.editorconfigand Dependabot.Tests
StoredHashCompatibilityTests: Argon2id, scrypt, bcrypt$2a$/$2b$/$2y$and ASP.NET Identity v2/v3 hashes, all generated with 7.1.2. Each one must verify (or returnSuccessRehashNeededfor Identity hashes) and must reject a wrong password. Never regenerate these values.CI
actions/checkout@v5andactions/setup-dotnet@v5, with the SDK taken fromglobal.json.-n.-p:Versionis used, so the assembly version matches the release.RepositoryBranchwasmainand is nowmaster.ContinuousIntegrationBuildis set only on CI.Test plan
dotnet build -c Release: 0 errors. The only warnings are the existing CS1591 (missing XML docs).dotnet test -c Release: 59/59 passed, including 11 new compatibility testsdotnet list package --vulnerable --include-transitive: no vulnerable packagesdotnet pack: four nupkg + snupkg files,net10.0group only, UTF-8 README, icon includedFollow-up (not in this PR)
BCrypt.Net-Core1.6.0 is an old port.BCrypt.Net-Nextis the maintained library. Switching is now safer because the compatibility tests guard existing hashes.🤖 Generated with Claude Code