Repository navigation
chore: drop the deprecated IdentityServer4 package - #85
Merged
Merged
Conversation
IdentityServer4 4.1.2 is EOL, built for .NET Core 3.1 and has advisories that will never be fixed. 11.0.0 is the last version of NetDevPack.Security.Jwt.IdentityServer4; it will be marked as deprecated on nuget.org. Removes the project and samples/3_IdentityServer4, and with them the only NU1902 suppression, the CI vulnerability exception and the Dependabot ignore rule. ADR-006 supersedes ADR-002.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
IdentityServer4 4.1.2 is EOL since 2022, was built for .NET Core 3.1 and has advisories that will never be fixed (GHSA-55p7-v223-x366, GHSA-ff4q-64jc-gx98). Since everything now targets .NET 10 (ADR-005), we kept shipping a new version of a package nobody should adopt, just to stay compatible.
What changes
src/NetDevPack.Security.Jwt.IdentityServer4andsamples/3_IdentityServer4from the repo and the solution. 11.0.0 is the last version ofNetDevPack.Security.Jwt.IdentityServer4.IdentityServer4andNewtonsoft.JsonfromDirectory.Packages.props. Only that project used them.CLAUDE.md/AGENTS.mdare updated as well.Release
chore:→ no new version. The other packages' public API doesn't change.After merging
Mark every version of
NetDevPack.Security.Jwt.IdentityServer4as deprecated on nuget.org (Legacy + Critical bugs). Suggested alternative:NetDevPack.Security.Jwt.AspNetCore.Validation
dotnet list package --vulnerable --include-transitive: no vulnerable packages in any project.