Repository navigation
fix(deps): patch vulnerable crypto packages - #82
Merged
Merged
Conversation
System.Security.Cryptography.Xml/Pkcs 10.0.12 (pulled by 10.0.0) have high severity advisories. Pin the patched versions per TFM (8.0.5/8.0.2, 9.0.23, 10.0.15) and bump the Microsoft.* packages to the latest patch of each line (8.0.34, 9.0.23, 10.0.15). The PR vulnerability check now ignores only the accepted IdentityServer4 advisory (ADR-002).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security patch for the 10.x line (net8.0 / net9.0 / net10.0). It should release 10.0.1.
NetDevPack.Security.Jwt10.0.0, the current package on nuget.org, depends onSystem.Security.Cryptography.XmlandPkcs10.0.12 on net10.0. Both now have high severity advisories, so every consumer of 10.0.0 gets vulnerable packages.Changes
Directory.Packages.props: pins the patched versions per TFM. WithCentralPackageTransitivePinningEnabled, they end up in the nuspec ofNetDevPack.Security.Jwt, so consumers get them as well.PR workflow: the vulnerable package check failed on the IdentityServer4 advisory that ADR-002 accepts. It now ignores only that package. The same fix is in feat!: target .NET 10 only #81.
This does not replace #81 (.NET 10 only, v11). It gives consumers on .NET 8/9 a patched 10.x. When #81 is rebased on top of this,
Directory.Packages.propskeeps only the net10 line.Test plan
dotnet build -c Release: 0 errorsdotnet test -c Release: 514 + 2 tests on each of net8.0, net9.0 and net10.0, all passeddotnet list package --vulnerable --include-transitive: only IdentityServer4 (accepted, ADR-002)dotnet pack: theNetDevPack.Security.Jwtnuspec has the patched Xml/Pkcs versions in each TFM group