Repository navigation
feat!: target .NET 10 and migrate to Fido2 4 - #5
Merged
Merged
Conversation
- Target net10.0 only (library and demo); drop net8.0/net9.0 (end of support 2026-11-10) - Fido2 / Fido2.AspNet 3.0.1 -> 4.3.3; removes vulnerable System.IdentityModel.Tokens.Jwt 6.17 (GHSA-59j7-ghrg-fj52) - New StoredCredential model (Fido2 4 no longer ships Fido2NetLib.Development.StoredCredential), same property names as 3.x, plus IsBackupEligible/IsBackedUp and StoredCredential.FromRegisteredCredential(RegisteredPublicKeyCredential) - StoredCredentialDetail: new IsBackupEligible and IsBackedUp columns (additive, default false) - IFido2Store.UpdateCounter accepts the Backup State flag; GetCredentialByPublicKeyIdAsync returns StoredCredential? - Transports parsing accepts enum names and WebAuthn values and ignores unknown values - Demo: Fido2 4 *Params API, assertion failures via Fido2VerificationException, error payload for the JS client, remove Microsoft.VisualStudio.Web.CodeGeneration.Design (vulnerable NuGet.* / Pkcs), Microsoft.* 10.0.15, Docker build context is the repository root - Central Package Management, NuGet Audit as errors, global.json (Microsoft.Testing.Platform), .editorconfig, dependabot - Tests: new xunit.v3 + AwesomeAssertions project running the store on SQLite in-memory - CI: actions/checkout v7, setup-dotnet v6, Release build/test, vulnerable package check, semantic-release 24, pack/push only on release, symbols pushed, package icon and README - CopyHook resolves paths from the project directory and is skipped on CI BREAKING CHANGE: targets .NET 10 and Fido2 4 only. Fido2NetLib.Development.StoredCredential was replaced by NetDevPack.Fido2.EntityFramework.Store.Model.StoredCredential. IFido2Store.UpdateCounter has a new optional isBackedUp parameter and GetCredentialByPublicKeyIdAsync returns a nullable value. The StoredCredentialDetail table gets two new non-nullable bool columns (IsBackupEligible, IsBackedUp) with default false: add an EF Core migration; no existing column is renamed or removed.
nuget.org API keys expire and the org key already did, which made the last releases fail with 403. Publish with NuGet/login (OIDC) instead: the job gets a short-lived key from the trusted publishing policy for this repository and workflow file. Also adds a workflow_dispatch input to publish an existing release tag again, since re-running the job skips the push once the release exists.
Member
Author
|
Added NuGet trusted publishing (OIDC) to the publish workflow, since the org API key expired. Same change as NetDevPack/NetDevPack#71: |
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
## [4.0.0](v3.0.0...v4.0.0) (2026-11-18) ### ⚠ BREAKING CHANGES * targets .NET 10 and Fido2 4 only. Fido2NetLib.Development.StoredCredential was replaced by NetDevPack.Fido2.EntityFramework.Store.Model.StoredCredential. IFido2Store.UpdateCounter has a new optional isBackedUp parameter and GetCredentialByPublicKeyIdAsync returns a nullable value. The StoredCredentialDetail table gets two new non-nullable bool columns (IsBackupEligible, IsBackedUp) with default false: add an EF Core migration; no existing column is renamed or removed. * ci: use conventionalcommits release preset * ci: publish to NuGet with trusted publishing nuget.org API keys expire and the org key already did, which made the last releases fail with 403. Publish with NuGet/login (OIDC) instead: the job gets a short-lived key from the trusted publishing policy for this repository and workflow file. Also adds a workflow_dispatch input to publish an existing release tag again, since re-running the job skips the push once the release exists. ### Features * target .NET 10 and migrate to Fido2 4 ([#5](#5)) ([d920813](d920813))
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the store to .NET 10 (LTS) and Fido2 4.3.3. .NET 8 and .NET 9 reached end of support on 2026-11-10. Fido2 4 also removes the vulnerable
System.IdentityModel.Tokens.Jwt/Microsoft.IdentityModel.JsonWebTokens6.17 (GHSA-59j7-ghrg-fj52).Breaking changes (release 4.0.0)
net10.0only. Users on .NET 8/9 or Fido2 3 stay on 3.x.Fido2NetLib.Development.StoredCredentialno longer exists in Fido2 4. The store now has its ownNetDevPack.Fido2.EntityFramework.Store.Model.StoredCredential.UserId,Descriptor,PublicKey,UserHandle,SignatureCounter,CredType,RegDate,AaGuid). Most code only needsusing NetDevPack.Fido2.EntityFramework.Store.Model;instead ofusing Fido2NetLib.Development;.IsBackupEligible/IsBackedUpproperties.StoredCredential.FromRegisteredCredential(RegisteredPublicKeyCredential). It also keeps transports, which the old demo dropped.IFido2Store.GetCredentialByPublicKeyIdAsyncreturnsStoredCredential?.IFido2Store.UpdateCounter(byte[] credentialId, uint counter, bool? isBackedUp = null)can also store the Backup State flag (VerifyAssertionResult.IsBackedUp). Existing source calls still compile.Database schema (additive only)
StoredCredentialDetailgets two columns. Nothing is renamed or removed:IsBackupEligiblefalseIsBackedUpfalse(refreshed on next login whenUpdateCounter(..., result.IsBackedUp)is used)Consumers run
dotnet ef migrations add Fido2StoreV4(the migration isAddColumn<bool>(..., defaultValue: false)). The README has the steps and the SQL Server equivalent. A test reads a row in the 3.x format to make sure it still loads: transports as enum names, no backup flags, nullType.Library changes
Usb) and WebAuthn values (usb,smart-card). It ignores unknown values instead of throwing.UpdateCounterusesSaveChangesAsync.InternalsVisibleTofor the test project.PackageIconUrlis deprecated) and README in the packageRepositoryBranch=mainDemo
MakeNewCredentialParams,MakeAssertionParams,RequestNewCredentialParamsandGetAssertionOptionsParams.ResidentKeyreplacesRequireResidentKey.RawId.Fido2VerificationException.status/errorMessage. The JS now checksstatus === "error", which only the controller's own error payload sets.Microsoft.VisualStudio.Web.CodeGeneration.Design, the source of vulnerableNuGet.*andSystem.Security.Cryptography.Pkcs9.0.4. Microsoft.* packages updated to 10.0.15.NetDevPack8.0.2, because 9.0.0 (feat!: target .NET 10 and update dependencies NetDevPack#65) is not published yet. Bump it after that release.docker build -f demo/Fido2.Passwordless/Dockerfile .). The old context could not resolve../../src.Build, tests, CI
global.jsonwith the SDK 10 + Microsoft.Testing.Platform runner..editorconfigand Dependabot.IFido2Storeagainst SQLite in-memory, so the real SQL translation ofbyte[]comparisons is exercised. It covers:actions/checkout@v7andactions/setup-dotnet@v6, with the SDK taken fromglobal.json.--skip-duplicateand symbols pushed.CopyHookresolves paths from the project directory and is skipped on CI.Test plan
dotnet build -c Release: 0 errors. Warnings are the existing nullable annotations in the demo and inStoredCredentialDetail.dotnet test: 7/7 passeddotnet list package --vulnerable --include-transitive: no vulnerable packages (library, demo and tests)dotnet pack: singlenet10.0group (Fido2 4.3.3, Microsoft.EntityFrameworkCore 10.0.15), icon and README included