Fix MCP tool name to match server instructions and README - #1
Open
prateekbhujel wants to merge 1 commit into
Open
Fix MCP tool name to match server instructions and README#1prateekbhujel wants to merge 1 commit into
prateekbhujel wants to merge 1 commit into
Conversation
Add explicit #[Name('app-info')] attribute on AppInfoTool so JSON-RPC
tools/list and tools/call resolve the tool as advertised in the
SuperStackServer instructions and README. Also sync nativephp/web-ui into
package versions and add MCP feature tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SuperStackServerinstructs clients to useapp-info:And
README.mddocuments:Without an explicit
#[Name]attribute,Primitive::name()defaults toStr::kebab(class_basename($this)), registering the tool asapp-info-tooland causing MCP clients following the instructions/docs to receive:{"jsonrpc":"2.0","id":1,"error":{"code":-32602,"message":"Tool [app-info] not found."}}Changes
#[Name('app-info')]toAppInfoToolso the tool name matches the server instructions and README.nativephp/web-uiinto the package list returned byAppInfoToolto matchHome.php.tests/Feature/McpServerTest.phpcoveringtools/list,tools/call, and unknown tool error handling.