feat: add lifecycle ignore for data_collection_rule_id on LAW module - #318
Merged
Conversation
rfk-nc
approved these changes
Aug 27, 2026
hardik-desai-nhs
force-pushed
the
fix/law-drc-link-drift-fix
branch
from
August 27, 2026 10:36
6923702 to
7f2af06
Compare
|
Warren-Pitterson
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added lifecycle Ignore for data_collection_rule_id so that up stream apps can set their own dcrId
Context
currently in dtos-cohort-manager we have a dcr that excludes some of the successful health check logs to reduce the size and cost of of the AI instance, but due to the fact that the DCR needs to be applied at LAW level and the LAW defined as template gets deployed before the drc and removes the link then dcr gets deployed but they are not linked hence rendering it useless
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.