Skip to content

docs(specs): sync and reorganize tasks.md for 004 and 005 - #340

Open
Matobi98 wants to merge 1 commit into
MostroP2P:mainfrom
Matobi98:docs/sync-tasks-004-005
Open

docs(specs): sync and reorganize tasks.md for 004 and 005#340
Matobi98 wants to merge 1 commit into
MostroP2P:mainfrom
Matobi98:docs/sync-tasks-004-005

Conversation

@Matobi98

Copy link
Copy Markdown
Contributor

Summary

Two docs chores from #122, both covering specs/*/tasks.md files that had drifted from reality.

specs/005-transport-v2-migration/tasks.md

All 12 tasks were still [ ] even though the transport migration merged in #111 and was verified end-to-end. Marked all 12 done, and added a status note at the top: the plan is now a historical record, not a map of the current code. Verified against current code, it's been superseded further than the issue assumed — mostro-core is now 0.14.1 (past the 0.13.1 target), gift_wrap.rs no longer exists (wrap_mostro_message/unwrap_mostro_message now live in rust/src/nostr/transport.rs), and T011's "leave gift wrap on peer/dispute chat untouched" no longer holds, since that chat also moved off gift wrap entirely in #246/#254.

specs/004-mostro-p2p-client/tasks.md

Three changes:

Docs-only change, no code touched.

Closes #122

Test plan

  • Read both files fully before editing to confirm the actual state (checked boxes, phase structure, existing notes) rather than assuming the issue's description was still accurate
  • Cross-checked the corrected claims against the current code (mostro-core version, file layout, chat transport) the same way as in README: explicitly list supported NIPs and BUDs #123
  • N/A, no Rust/Dart code changed, so cargo fmt/clippy/test and flutter analyze/test do not apply

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 6ace3872-511e-4f34-96c1-8fb366fdc0b2


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ermeme ermeme Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head 978d76d7e85b4a76d2de7ba88118389dc28bdef8.

Blocking documentation issues

This PR claims to synchronize the task plans with reality, but the new “Open work at a glance” omits a major existing gap: T010 remains marked [x] even though rust/src/db/indexeddb.rs still returns IndexedDB not yet implemented for orders, trades, relays, identity, and queued messages. The task text says the IndexedDB backend must support all 11 entities, so marking it complete and claiming that almost everything through T145 is done is materially inaccurate. Either mark T010 as partial/not done and include it in the open-work summary, or update the task wording/status to match the actual supported scope.

Also, the new historical transport note correctly says peer/dispute chat moved off gift wrap, but the corresponding historical T011 still says it was completed by leaving gift wrap untouched. If this file is intended as a truthful current-status record, annotate that task as superseded (as done in the 005 file) rather than leaving a completed task whose acceptance text is now false.

These are correctness blockers for a PR whose stated purpose is syncing the task documents. No CI checks are configured for this docs-only PR.

@Catrya Catrya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Matobi98 please fix the conflicts and address the hermemes review, thanks!

Marks the 12 spec-005 transport-migration tasks done (merged in MostroP2P#111,
verified end-to-end) and notes the plan describes pre-refactor file
and version names.

For spec-004: adds an "open work at a glance" summary pointing at the
real backlog, downgrades T010 (IndexedDB) to partial — only messages,
settings and the active Mostro pubkey are implemented, everything else
still returns "IndexedDB not yet implemented" (MostroP2P#233) — flags the
historical gift-wrap tasks T011/T012 as superseded inline (the blanket
transport note already covers the rest), and adds a pointer task for the
mnemonic-restore flow that has a contract but no task entry (defers the
actual breakdown to epic MostroP2P#142).

The transport-v2 note itself is left as upstream rewrote it in 61fa304;
this branch's earlier edit to the same line said the same thing less
precisely and was dropped on rebase.

Closes MostroP2P#122

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNuovaCqxF9uWSqRGwEcpq
@Matobi98
Matobi98 force-pushed the docs/sync-tasks-004-005 branch from 978d76d to 74d0dcd Compare September 4, 2026 20:09
@Matobi98

Matobi98 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review — both blockers addressed in the rebased head.

  1. Conflicts: rebased onto main (179 commits). The only clash was the Transport v2 note, which upstream had already rewritten in 61fa304 — I dropped my edit of that line and kept upstream's.

  2. T010: now [~] with the real scope spelled out — only messages, settings and the active Mostro pubkey are backed by real object stores; orders, trades, relays, identity, queued messages and trade keys still return IndexedDB not yet implemented (Web: IndexedDB storage backend is a stub — nothing persists across a reload #233). Added as the first bullet in "Open work at a glance" (phase order), and fixed the surrounding claims: "Almost everything below (T001–T145) is [x]" → "Most of what follows…", and "two clusters" → "three clusters".

  3. Superseded tasks: added (Superseded — see the Transport v2 note above.) inline on 004's T011 and T012, the two that name Kind 1059 explicitly; the rest of the historical set stays covered by the block note. 005's T011 already carried that annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: sync and reorganize tasks.md for specs 004 and 005

2 participants