Repository navigation
Fix CI on Flutter 3.50: refresh lockfile, upgrade melos, migrate to material_ui - #558
Merged
Merged
Conversation
melos 8.9.0 fails to start on Dart 3.14 (cli_launcher cannot locate the installation); melos 8.10.1 with cli_launcher 0.3.4+1 works. The lockfile also picks up the resolution changes that made the committed-lockfile check fail.
Flutter 3.50 deprecates package:flutter/material.dart, which made flutter analyze fail in every example. - examples, tests and benchmarks import package:material_ui/material_ui.dart - lib code that only needs widgets, foundation or cupertino imports narrower libraries instead of Material - mixin_markdown_widget uses material_ui for its public Material types and now requires Dart ^3.13.0 / Flutter >=3.47.0; fix the lints enabled by the new language version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainCI failed onCheck committed lockfile(stalepubspec.lock) and Integration Tests (deprecated_member_useonpackage:flutter/material.dartunder Flutter 3.50).mixin_markdown_widget0.5.0 requires Dart ^3.13 / Flutter >=3.47.MarkdownThemeDatanow extends thematerial_uiThemeExtension, which is a different type from Flutter's legacy one.Evidence
mainruns 43387469001 (CI) and 43387468955 (Integration Tests) failed.After (local, not CI):
melos run analyze,melos run format, andflutter analyze --no-pubin all 16 examples exit 0;mixin_markdown_widgetflutter test282 passed (was 264 passed / 17 failed when half-migrated); a seconddart pub getleavespubspec.lockunchanged;dart pub publish --dry-run0 warnings.Merge Danger
Door: two-way for the repo; one-way once
mixin_markdown_widget0.5.0 is published.Blast Radius:
mixin_markdown_widgetconsumersApps must switch to
material_uiforMaterialApp/Theme/ThemeDatato use 0.5.0.flutter-apppins^0.4.0, so it does not pick this up automatically. This PR does not publish; that needs the tagmixin_markdown_widget-v0.5.0.