Skip to content

desktop_webview_window: fix crash on app exit on Windows #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boyan01 merged 2 commits into from
Nov 13, 2026
Merged

desktop_webview_window: fix crash on app exit on Windows #557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26ceaaa
desktop_webview_window: fix crash on app exit on Windows
mtallenca Nov 12, 2026
00657b6
Remove generated string_tokenizer example files committed by mistake
mtallenca Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/desktop_webview_window/windows/web_view_window_plugin.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,13 @@ WebviewWindowPlugin::WebviewWindowPlugin(flutter::BinaryMessenger* messenger)
}

WebviewWindowPlugin::~WebviewWindowPlugin() {
channel_->SetMethodCallHandler(nullptr);
// The handler is deliberately left registered. A plugin is destroyed while
// its engine shuts down, and ~FlutterWindowsEngine detaches the messenger
// from the engine before it runs the registrar's destruction callback, so
// clearing the handler here dereferences a null engine and crashes the app
// on exit. An engine that is shutting down dispatches nothing more to it.
lifetime_.reset();
// Close windows while the engine is still alive.
// Close the windows before the channel they were emitting on goes away.
auto windows = std::move(windows_);
for (const auto& entry : windows) {
entry.second->Close();
Expand Down
Loading