Repository navigation
should check nonce hash in processConfirmNonce - #37
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical confirmation-handling issues can cause repeated replay crashes, incorrect legacy decoding, and nonce-expiry delays that hold up newer calls.
3 open issues
What changed in this PR
Strengthens Solana system-call confirmation by validating the durable nonce before creating withdrawals and signing sessions.
Changes:
- Adds the nonce hash to observer confirmation payloads and updates decoding.
- Validates the transaction’s blockhash and nonce-advance program, accounts, authority, and sysvar.
- Adds tests for missing, truncated, and incorrect nonce hashes.
| File | Description |
|---|---|
| solana/system_call.go | Adds the system-call nonce validator. |
| solana/observer.go | Includes the nonce hash in available confirmations. |
| solana/mvm.go | Validates the nonce and updates prepare-call decoding. |
| solana/computer_test.go | Tests invalid nonce payload rejection and updates valid confirmations. |
Review effort: Max
Comment on lines
+337
to
+340
| if len(extra) < uuid.Size+32 { | ||
| return node.failRequest(ctx, req, "") | ||
| } | ||
| nonceHash := solana.HashFromBytes(extra[uuid.Size : uuid.Size+32]) |
Comment on lines
646
to
+648
| if failureReason == "" { | ||
| nonceHash := solana.MustHashFromBase58(nonce.Hash) | ||
| extra = append(extra, nonceHash[:]...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.