Fix relief rendering on Minecraft 1.17.1 - #150
Merged
SkyBlade1978 merged 2 commits intoSep 2, 2026
Merged
Conversation
SkyBlade1978
merged commit Sep 2, 2026
4683bfa
into
MinecraftModDevelopmentMods:master-1.17.1
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
6.1.0.117011to6.1.1.117011Cause and fix
RockReliefalready returned an empty visual shape, but its thin full-face shape remained the occlusion shape. Minecraft 1.17 therefore culled the supporting block face behind the open model centre. The block now also returnsShapes.empty()fromgetOcclusionShape.This changes no registry IDs, NBT, recipes, world generation, OreSpawn integration, or existing-world identities.
Validation
clean check build javadoc verifyReleaseConfiguration verifyReleaseDependencies verifyReleaseArtifacts writeReleaseChecksumsgenEclipseRuns eclipse isolateEclipseProductionRuns verifyEclipseProductionClasspathgit diff --check4AB24679C9F996F32E8E58398065A8D2681A90C27241510F067E4045014F9B1ENo tag or publication is included in this PR.