chore(smart-transactions-controller): remove STX migration flags - #9996
Open
rarquevaux wants to merge 1 commit into
Open
chore(smart-transactions-controller): remove STX migration flags#9996rarquevaux wants to merge 1 commit into
rarquevaux wants to merge 1 commit into
Conversation
rarquevaux
force-pushed
the
chore/remove-migration-flags
branch
4 times, most recently
from
August 28, 2026 15:57
ded821d to
3a05617
Compare
rarquevaux
marked this pull request as ready for review
August 28, 2026 16:04
rarquevaux
force-pushed
the
chore/remove-migration-flags
branch
from
August 28, 2026 16:04
3a05617 to
4cf0178
Compare
Migration to sentinel-api is complete. Remove `stxMigrationGetFees`, `stxMigrationSubmitTransactions`, `stxMigrationCancel`, and `stxMigrationBatchStatus` remote feature flags, the `#isStxMigrationFlagEnabled` gate, and the `API_BASE_URL` fallback — all API calls now always route to the sentinel API. `getAPIRequestURL` now throws for chains not in the sentinel map.
rarquevaux
force-pushed
the
chore/remove-migration-flags
branch
from
August 28, 2026 16:26
4cf0178 to
9c09c4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #Incident-Metamask-1820..
The changes are limited to removing the usage of the
stxMigrationflags that have been broken by a change made in theremote-flags-controller. MetaMask/metamask-extension#45406A lot more improvements are possible here, most notably add the endpoint to
sentinel-api-servicebut are out of scope of this fix.Note
Medium Risk
Changes where every STX fee, submit, status, and cancel request goes (sentinel-only, breaking
API_BASE_URLexport); misconfigured or unsupported chains will error instead of hitting the legacy API.Overview
Smart transaction HTTP traffic is pinned to the tx-sentinel API instead of toggling between the legacy
transaction.api.cx.metamask.iohost and sentinel via remote flags.The controller drops
#isStxMigrationFlagEnabledand thestxMigration*remote flags for getFees, submit, cancel, and batchStatus.getAPIRequestURLno longer accepts auseSentinelargument: it always builds/v1/networks/{chainId}/…URLs fromSENTINEL_API_BASE_URL_MAP, and throws if the chain is missing from that map (no legacy fallback). The publicAPI_BASE_URLconstant is removed, and bearer-token injection in#fetchonly applies to sentinel base URLs.Tests and changelog are updated to match; Jest coverage thresholds are nudged down slightly after removing flag-routing tests.
Reviewed by Cursor Bugbot for commit 9c09c4b. Bugbot is set up for automated code reviews on this repo. Configure here.