fix(kyc-controller): Send residenceCountry and sessionClientPublicKey on kyc session creation - #9993
Merged
Merged
Conversation
jiexi
changed the title
Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 578d94e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Changes the UKYC session contract and crypto wiring for document verification; consumers calling
createUkycSessiondirectly must adopt the new required fields.Overview
BREAKING:
KycService.createUkycSession(POST /sessions) now requiressessionClientPublicKey(unpadded base64url X25519) andresidenceCountry(ISO 3166-1 alpha-3). Direct callers must supply both; the controller generates the per-session keypair, registers the public key at session creation, and uses the private key with the existingwrapEncryptionKeypath forsetAuthorizations.KycControllerresolvesresidenceCountryfromgeoCountryorKycService:getGeoCountry, persists it on state when fetched, and aborts UKYC session creation ifreset()bumps the flow generation while geo is in flight.Removes the unused
wrapUserKeyhelper and its tests; docs andwrapEncryptionKeycomments now describe explicit session client public-key registration instead of implying registration was absent.Reviewed by Cursor Bugbot for commit 578d94e. Bugbot is set up for automated code reviews on this repo. Configure here.