feat(ramps-controller): add autoramp, NeoBank client, and Money Account wallet registration - #9930
Open
jiexi wants to merge 3 commits into
Open
feat(ramps-controller): add autoramp, NeoBank client, and Money Account wallet registration#9930jiexi wants to merge 3 commits into
jiexi wants to merge 3 commits into
Conversation
4 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
amitabh94
previously approved these changes
Aug 24, 2026
matteyusys
reviewed
Aug 24, 2026
| machine = transitionWalletRegistration(machine, { | ||
| type: 'LOOKUP_FAILED', | ||
| }); | ||
| throw error; |
Contributor
There was a problem hiding this comment.
are we able to return a result here so it can be acted on rather than throwing an error? Maybe a failure result type we can use on the client?
So client side, might look something like:
const result = await rampsController.registerMoneyAccountWallet({ address });
switch (result.type) {
case 'registered':
case 'alreadyRegistered':
// continue onboarding
break;
case 'registeredDisabled':
// show “wallet disabled” UX
break;
case 'failedRetryable':
// show Retry
break;
case 'failedTerminal':
// show a hard error, don’t retry
break;
}
Member
Author
There was a problem hiding this comment.
adding a lookupUnavailable type for now 220c325
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 39f5d3c. Configure here.
…nt wallet registration Land the neobank-proxy autoramp and wallet-registration surfaces on RampsController with Profile Sync customer-id resolution, so money-movement can ship independently of the multi-vendor KYC PR. Co-authored-by: Cursor <cursoragent@cursor.com>
jiexi
force-pushed
the
feat/ramps-controller-autoramp-neobank
branch
from
August 25, 2026 18:24
39f5d3c to
0301430
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RampsController(CRUD, push apply, user-storage backup) and resolve vendorcustomer_idfrom Profile Sync (getSessionProfile→getCustomerByExternalId).KycController:getCustomerIdentityyet.Test plan
yarn workspace @metamask/ramps-controller run testAuthenticationController:getSessionProfileandKeyringController:signPersonalMessage(seeRAMPS_CONTROLLER_REQUIRED_CONTROLLER_ACTIONS)customer_idwith the Profile Sync → neobank-proxy mappingregisterMoneyAccountWallet({ address })looks up the customer, signs the ownership message, and reconciles 409 / transient failuresMade with Cursor