Repository navigation
refactor(mac): split Magnifier.step into tick phases (#1) - #593
Merged
Merged
Conversation
7 of 8 tasks
Part of #579 (#1, part A). step(_:) now calls beginTick, writeLevelFirst, readPointer, endSessionAt1x, startSessionIfNeeded, readRawAndHoldBack, detectLock, resolveOwner, computeTarget, commitView and finishTick, with a private TickCtx carrying the tick's locals. Every moved line is unchanged and in the same order; the .mouse case moves whole. The prevRawMotion / prevRawStep defer stays in the driver after readRawAndHoldBack, so it runs on every exit as before. No behaviour change. Docs: tick-phase map in mac/docs/architecture.md and a gotcha in mac/CLAUDE.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kg7JN6ZPh3N5p9541yz3Bv
After the rebase onto #596: its bare return in step() moved into endSessionAt1x, which returns Bool. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kg7JN6ZPh3N5p9541yz3Bv
Maxaubert
force-pushed
the
refactor/mac-step-phases
branch
from
November 18, 2026 20:40
8caccc8 to
4f53946
Compare
Maxaubert
marked this pull request as ready for review
November 18, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #579 (audit #1). Plan: research/wind/2026-11-18-audit-refactor-plan.md, PR 9, part A only.
Magnifier.step(_:)is now a short driver over private phases:beginTick,writeLevelFirst,readPointer,endSessionAt1x,startSessionIfNeeded,readRawAndHoldBack,detectLock,resolveOwner,computeTarget,commitView,finishTick. ATickCtxstruct carries the tick's locals. Moved lines are byte-identical; only the early returns (return nil/return true) and theprevRawdefer (now in the driver right afterreadRawAndHoldBack) changed form. The.mousecase moves whole (part B, splitting it, is deferred). Docs: a tick-phase section inmac/docs/architecture.mdand a line inmac/CLAUDE.md.Draft until the Mac checks run. Not compiled locally (no Swift on the PC, Mac unreachable over SSH).
mac.ymlcompiles it and runswind-checks. Still owed on the Mac: alogLevel=2before/after diff of theview/wcurlines, the e2e and*_truthscripts, andscripts/build.sh install. Opus review: no behaviour change found.🤖 Generated with Claude Code
https://claude.ai/code/session_01Kg7JN6ZPh3N5p9541yz3Bv