Now Repeated and RepeatedNull can use regular format rules - #1940
Merged
Conversation
Member
rocky
changed the title
Repeated and RepeatedNull can use regular format rules
rocky
force-pushed
the
improve_format_repeated_repeated_null
branch
from
September 7, 2026 13:32
a837141 to
bbd29cd
Compare
rocky
force-pushed
the
improve_format_repeated_repeated_null
branch
from
September 7, 2026 16:02
bbd29cd to
e5f6320
Compare
Member
|
@mmatera Note that after all of this, I do not think #1932 is fully addressed. I'll check again, but I am still getting an infinite recursion error. Also, something as simple as (That said, I think that after the dust settles a bit, all of this will be great progress. Thanks!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a first payoff of the previous fixes #1938 and #1939: we can move the special cases of Repeated and RepeatedNull format rules that had to be handled in a hard-coded way to the regular format rules mechanism.
The issue with the infinite recursion in Condition seems to be related to the infinite recursion these patterns produced.