<fix>[lb]: reject tcp ipvs on old zvr

[zstack-robot-2]

Summary

Cloud rejects unsupported TCP IPVS listener requests before persistence, including old ZVR appliances and HAProxy-only Proxy Protocol settings.

Behavior Changes

• Reject shared-VRouter TCP IPVS creation when the target ZVR version is missing, invalid, or lower than 5.5.38.0; no listener record is persisted on failure.
• Reject tcpProxyProtocol=v1/v2 for TCP IPVS listeners; disable remains accepted.

Structural Changes

• LoadBalancerBackend.validateBeforeCreateListener(...) performs provider-specific validation before LoadBalancerBase persists the listener.
• virtualRouterProvider resolves the target appliance and checks VirtualRouterMetadataVO.zvrVersion.
• The listener interceptor rejects enabled Proxy Protocol only for TCP IPVS, without changing HAProxy behavior.

Test Coverage

• TcpIpvsZvrVersionValidationCase covers old-ZVR rejection, supported-ZVR creation, rollback and fixture cleanup.
• TcpIpvsLoadBalancerListenerApiCase covers TCP IPVS Proxy Protocol rejection and the accepted disable value.
• Live API validation on 172.25.116.3 confirmed version/proxy-protocol failures leave no listener residue.

Resolves: ZSTAC-86989, ZSTAC-86990

sync from gitlab !10764

[coderabbitai]

Warning

Review limit reached

Next included review available in 55 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 61 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b853ba01-4fd0-4ba3-81c3-8c24748ecf45

📥 Commits

Reviewing files that changed from the base of the PR and between 416fc53 and e898a7e.

📒 Files selected for processing (9)

• plugin/loadBalancer/src/main/java/org/zstack/network/service/lb/LoadBalancerApiInterceptor.java
• plugin/loadBalancer/src/main/java/org/zstack/network/service/lb/LoadBalancerBackend.java
• plugin/loadBalancer/src/main/java/org/zstack/network/service/lb/LoadBalancerBase.java
• plugin/loadBalancer/src/main/java/org/zstack/network/service/lb/LoadBalancerManagerImpl.java
• plugin/virtualRouterProvider/src/main/java/org/zstack/network/service/virtualrouter/lb/VirtualRouterLoadBalancerBackend.java
• plugin/virtualRouterProvider/src/main/java/org/zstack/network/service/virtualrouter/vyos/VyosConstants.java
• test/src/test/groovy/org/zstack/test/integration/networkservice/provider/virtualrouter/loadbalancer/TcpIpvsLoadBalancerListenerApiCase.groovy
• test/src/test/groovy/org/zstack/test/integration/networkservice/provider/virtualrouter/loadbalancer/TcpIpvsZvrVersionValidationCase.groovy
• utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

Parsing errors (1)

Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation timed out.

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

---

_{Comment @coderabbitai help to get the list of available commands.}