Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #243 where passing
non_rigid_reg_paramswhennon_rigid_registrar_clsis a class object results in:UnboundLocalError: local variable 'non_rigid_registrar_obj' referenced before assignmentCause
In
valis/registration.py(line 4895), when instantiatingnon_rigid_registrar_clswith custom parameters:the unassigned variable
non_rigid_registrar_objwas referenced and assigned to unusednr, leavingnon_rigid_registrar_objundefined.Fix
Instantiate
non_rigid_registrar_clsand assign tonon_rigid_registrar_obj:This matches the correct implementation in
valis/serial_non_rigid.py(line 998).