Skip to content

feat: KaiselShell reports its active branch to the URL - #109

Merged
Mastersam07 merged 2 commits into
devfrom
fix/kaisel-shell-nested-state
Nov 12, 2026
Merged

Mastersam07 merged 2 commits into
devfrom
fix/kaisel-shell-nested-state

Conversation

@Mastersam07

Copy link
Copy Markdown
Owner

KaiselShell never registered with the delegate, so its stacks couldn't be deep linked or restored, which matters now that a single-branch KaiselShell is the recommended way to share a provider across a group of screens.

  • ShellRouter now reports its active branch like BranchedShellRouter, so codecs read and write it through KaiselShellConfig and its active branch survives a restart. Behaviour change: codecs now see nestedState for it.
  • A KaiselShell inside another shell, a module or a flow stays out of the URL, so existing URLs there don't change.
  • Docs: the restoration guide lists what still doesn't restore, the codec and shells guides cover KaiselShell, and the KaiselGuard comment no longer claims sync guards make navigation synchronous.
  • New tests in kaisel_shell_nested_state_test.dart.

github-actions Bot pushed a commit that referenced this pull request Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📖 Docs preview: https://kaisel.dev/pr-109/ (updates on every push; removed when this PR closes)

@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.58%. Comparing base (c752d83) to head (3a0e7bf).
⚠️ Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #109   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          44       44           
  Lines        2628     2670   +42     
=======================================
+ Hits         2617     2659   +42     
  Misses         11       11           
Flag Coverage Δ
kaisel 99.58% <100.00%> (+<0.01%) ⬆️
kaisel_core 99.58% <100.00%> (+<0.01%) ⬆️
kaisel_devtools 99.58% <100.00%> (+<0.01%) ⬆️
kaisel_lint 99.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mastersam07
Mastersam07 merged commit 12d17fa into dev Nov 12, 2026
7 checks passed
github-actions Bot added a commit that referenced this pull request Nov 12, 2026
@Mastersam07
Mastersam07 deleted the fix/kaisel-shell-nested-state branch November 12, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant