MDEV-40168 wip - #5620
Draft
mariadb-YuchenPei wants to merge 1 commit into
Draft
Conversation
|
|
mariadb-YuchenPei
force-pushed
the
bb-main-mdev-40168
branch
2 times, most recently
from
September 1, 2026 06:51
8a9c029 to
21cf57e
Compare
mariadb-YuchenPei
force-pushed
the
bb-main-mdev-40168
branch
from
September 1, 2026 07:51
21cf57e to
d3452c7
Compare
spetrunia
self-requested a review
September 1, 2026 09:05
spetrunia
reviewed
Sep 1, 2026
| t1 CREATE TABLE `t1` ( | ||
| `c` int(11) DEFAULT NULL, | ||
| `j` longtext CHARACTER SET utf8mb4 COLLATE utf8mb4_bin DEFAULT NULL CHECK (json_valid(`j`)) | ||
| ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_uca1400_ai_ci |
Member
There was a problem hiding this comment.
So, the index is now shown in SHOW CREATE TABLE ?
spetrunia
reviewed
Sep 1, 2026
| show index from t1; | ||
| Table Non_unique Key_name Seq_in_index Column_name Collation Cardinality Sub_part Packed Null Index_type Comment Index_comment Ignored | ||
| t1 1 invisible1 1 invisible1 A 0 NULL NULL YES BTREE NO | ||
| t1 1 idx 1 DB_MVI_1 NULL NULL NULL NULL YES FULLTEXT NO |
Member
There was a problem hiding this comment.
Do I miss something or the table has TWO indexes? one BTREE and one FULLTEXT?
Contributor
Author
There was a problem hiding this comment.
It's a side effect of the debug_dbug:
DBUG_EXECUTE_IF("test_invisible_index",{
LEX_CSTRING temp= "invisible1"_Lex_ident_column;
mysql_add_invisible_index(thd, &alter_info->key_list
, &temp, Key::MULTIPLE);
});
TODOs on top of those in the patch diff: - EXPLAIN output should not say fulltext - check type match to avoid false negative / positive bugs in mysql - transcode the value into the index charset in mvi_encode_key
mariadb-YuchenPei
force-pushed
the
bb-main-mdev-40168
branch
from
September 1, 2026 10:09
d3452c7 to
7cfaf2b
Compare
spetrunia
reviewed
Sep 2, 2026
| } | ||
| if (matches.elements == 1) | ||
| cond= matches.pop(); | ||
| else |
Member
There was a problem hiding this comment.
Note that this doesn't distinguish between AND/OR so for
explain select * from t100 where json_contains(js1->'$.tags', '"val-1"') OR json_contains(js2->'$.tags', '"val-2"');it will generate
json_contains(json_extract(t100.js1,'$.tags'),'"val-1"') or
json_contains(json_extract(t100.js2,'$.tags'),'"val-2"')) and
(match t100.DB_MVI_1 against ('76616c2d31' in boolean mode)) and
(match t100.DB_MVI_2 against ('76616c2d32' in boolean mode))
Member
There was a problem hiding this comment.
Let's just generate nothing for top-level ORs for the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODOs on top of those in the patch diff: