Repository navigation
Build the iOS core PNG encoder's simulator slice for x86_64 too - #4
Merged
Merged
Conversation
ios-sdk-core 1.4.1 ships an arm64+x86_64 simulator slice; without this the next rebuild would drop x86_64 again.
build-ios-core-png.sh now builds the x86_64 simulator slice, and the runner's toolchain lacked that target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ios-sdk-core 1.4.1 (MapConductor/ios-sdk-core#46) ships TilePng.xcframework with an
ios-arm64_x86_64-simulatorslice: Intel simulator builds, and CocoaPods trunk validation, failed to link without x86_64. This makesbuild-ios-core-png.shproduce the same slice (addsx86_64-apple-ios, lipo with the arm64 simulator build), so the next rebuild does not drop it. Needsrustup target add x86_64-apple-ios.