Repository navigation
Antenna sample: carrier icon toggles in a card under the map - #80
Merged
Merged
Conversation
The four carriers are now buttons with an icon drawn for this sample in each carrier's circle colour (not the carriers' logos), pressed when shown. The per-carrier counts are gone.
Its panel over the map hid most of it. SamplePageLayout now has a slot under the map stage, and BelowMapCard portals a page's options into it as a card (after mount, since portals do not render on the server). Other pages keep their ControlPanel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
public/antennas/carrier-*.svg) are drawn for this sample in each carrier's circle colour, a white tower on a coloured disc, not the carriers' logos. A button is outlined in the carrier's colour while its cells are shown, and greyed out while they are hidden (aria-pressed). The per-carrier counts are gone.ControlPanelover it, where they hid most of the map.SamplePageLayoutgains a slot under the map stage, andBelowMapCardportals a page's card into it. The card renders after mount, since portals do not render on the server, so the static page and the first client paint stay the same. Other pages keep theirControlPanel.The Android and iOS samples get the same change, with the same drawing, in their own PRs.
Checked
In the browser (dev server, MapLibre):
oxlintreports nothing new, andtschas no errors in the changed files.Not checked: phone width. The card uses the same margins as the documentation card.