Repository navigation
Point js-sdk-core at circle blocks stored by place - #69
Merged
Merged
Conversation
MapConductor/js-sdk-core#48: zoomed-in circle tiles read only the blocks round them (Pixel 5a, antenna-horizons: 3.5-5.4 s -> 0.09-0.6 s for 9 tiles).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings in MapConductor/js-sdk-core#48: large circle sets are stored by place, so a zoomed-in tile reads only the blocks round it. On a Pixel 5a, antenna-horizons goes from 3.5–5.4 s to 0.09–0.6 s for 9 tiles, and the tiles are byte-identical to before.
This points at the branch commit (226f4fb2d81ae54e0f11051d9df667f60cdf72ea) so that CI runs against the change. After #48 is merged, I'll point it at the merge commit before this is merged.