Repository navigation
Add progress callbacks for Markers/Circles/Polylines/Polygons - #67
Merged
Merged
Conversation
Points js-sdk-core and js-sdk-react at the add-progress branches (MapConductor/js-sdk-core#47, MapConductor/js-sdk-react#17).
Every sample with <Markers>, <Circles>, <Polylines> or <Polygons> puts up a small "Loading..." dialog between their onAddStart and onAddEnd. It waits 150 ms before showing, so quick lists do not flash it, and does not block the map. The Boston pages keep their own overlay, which already ends once every state is on the map. antenna-horizons uses it instead of its progress line.
js-sdk-core 47f6d0b (MapConductor/js-sdk-core#47, includes the service-worker fix from #68) and js-sdk-react d743b19 (MapConductor/js-sdk-react#17).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the submodules at MapConductor/js-sdk-core#47 and MapConductor/js-sdk-react#17.
antenna-horizons now shows "Adding to the map… added / total" between
onAddStartandonAddEnd. Merge the two submodule PRs first, then point this at their develop commits.