Repository navigation
Fit the samples to a phone screen - #66
Merged
Merged
Conversation
On a phone the map stage sat under the page title and two paragraphs, and an open control panel covered most of it; there was no way to see the map alone. - Under 760 px: one line of title (the description stays in the page but takes no room), and a stage that ends at the bottom of the screen. - ControlPanel's title folds the panel. Until it is pressed the width decides in CSS: open on a desktop, folded to its title on a phone; opened there it takes at most 55% of the stage and scrolls. Folding only hides the body, so the controls keep their state. - A full screen button on the stage: the Fullscreen API, or the stage fixed over the page where there is none (iPhone Safari). Escape leaves. Camera Sync keeps its own. - Camera Sync keeps only the selector and the numbers over each of its two maps on a phone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a phone (Pixel 5a), the samples showed the map in a short stage under the page title and two paragraphs. An open control panel covered most of the map, and there was no way to see the map alone. These changes are shared, so they apply to every sample page.
Layout under 760 px
ControlPanelControlPanel, so nothing changes per page.Full screen button (
SamplePageLayout)resizeevent, for maps that only resize on that.Camera Sync on a phone
Each of its two maps now carries only the provider selector and a compact line of numbers, so most of each map is visible.
Checks
tsc --noEmit -p examples/basicreports the same 11 existing errors asdevelop(inThreeMapObject,vite.config.tsandjs-sdk-core), and no new ones.