Skip to content

Read the antenna sample's state once when filtering - #35

Merged
wf9a5m75 merged 1 commit into
developfrom
perf/antenna-filter
Nov 21, 2026
Merged

wf9a5m75 merged 1 commit into
developfrom
perf/antenna-filter

Conversation

@wf9a5m75

@wf9a5m75 wf9a5m75 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

The antenna sample read its @State properties (carriers, rows, allCircles) inside the filter loop. Each read goes through SwiftUI's storage, and for 723,800 circles that cost 0.6 s in Debug. rebuild() now reads them once before the loop.

Goes with MapConductor/ios-sdk-core#49, which makes a carrier toggle go from 5.7–6.2 s to 0.95–1.2 s in Release on an iPad Pro 11-inch. This PR does not bump the ios-sdk-core submodule.

The carrier filter read three @State values for each of 723,800 cells: 0.6 s on the main thread on an iPad Pro (Debug), 0.4 s in Release. They are read once now.
@wf9a5m75
wf9a5m75 merged commit 5196699 into develop Nov 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant