Repository navigation
Read the antenna sample's state once when filtering - #35
Merged
Merged
Conversation
The carrier filter read three @State values for each of 723,800 cells: 0.6 s on the main thread on an iPad Pro (Debug), 0.4 s in Release. They are read once now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The antenna sample read its
@Stateproperties (carriers,rows,allCircles) inside the filter loop. Each read goes through SwiftUI's storage, and for 723,800 circles that cost 0.6 s in Debug.rebuild()now reads them once before the loop.Goes with MapConductor/ios-sdk-core#49, which makes a carrier toggle go from 5.7–6.2 s to 0.95–1.2 s in Release on an iPad Pro 11-inch. This PR does not bump the
ios-sdk-coresubmodule.