Repository navigation
Call onAddStart / onAddEnd for filter changes and tile drawing too - #48
Merged
Merged
Conversation
The collections called onAddStart only for a list that added states, and onAddEnd when those states' tiles were handed to the map, so an app could not tell that the map was still drawing after a filter that only hid states, or while the camera moved to undrawn tiles. - TileActivity: busy while a ShapeTiler routes a list or its ShapeTileRenderer draws a tile. Circle, polyline and polygon tilers expose it; a collection looks its map's tilers up through the provider's OverlayControllerRegistryKey when it joins the content. - AddProgressTracker counts as busy while states are coming, while those tilers are busy, and for 0.4 s after a hand-over: any list starts (total 0 when it adds nothing, nothing for an empty list after an empty one), drawing alone starts once it has lasted 0.2 s, and onAddEnd comes after 0.4 s with nothing coming, handed over or drawn. Callbacks still wait for the view update to end. Same rules as android-sdk-compose and js-sdk-react.
This was referenced Nov 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same rules as MapConductor/android-sdk-compose and MapConductor/js-sdk-react (PRs of the same name).
Why
Circles,PolylinesandPolygonscalledonAddStartonly for a list that added states, andonAddEndwhen those states' tiles were handed to the map. Drawing the tiles comes after that. A filter that only hides states, or a camera move to undrawn tiles, called nothing, so an app could not show that the map was still drawing.What
TileActivity: busy while aShapeTilerroutes a list or itsShapeTileRendererdraws a tile. The circle, polyline and polygon tilers expose it. A collection finds its map's tilers through the provider'sOverlayControllerRegistryKeywhen it joins the content.AddProgressTrackercounts as busy while states are coming, while those tilers draw, and for 0.4 s after a hand-over:totalis 0 when the list adds nothing. An empty list after an empty one calls nothing.onAddEndcomes after 0.4 s with nothing coming, handed over or drawn.onAddProgress(total, total)comes just before it whentotal> 0.All of it is
internal; no public API change. 566 tests pass.scripts/api-surface.sh check ios-sdk-corealready fails on develop: theonAdd*parameters added earlier are not in the recorded surface. This PR does not change that.Checked
Antenna sample (723,800 circles) on an iPad Pro 11-inch, Google Maps: after turning Verizon off the sample showed "Drawing the map…" and cleared it once the tiles were drawn. Turning it on showed "Adding to the map… 0 / 147,164".