Repository navigation
Store large circle sets by place, so a zoomed-in tile reads only the pages round it - #43
Merged
Merged
Conversation
…pages round it The circle geometry file kept its records in list order, so a tile's circles lay all over the mapping. CircleTileSet now writes it in Z-order of each circle's z12 cell (a stable radix sort of 24-bit keys, the same key as js-sdk-core and android-sdk-core). Indices stay the list's: CircleGeometryFile translates them in record(at:), and the passes over every shape (the grid index, the widest stroke) walk the storage order. Compaction keeps the order. Tiles are byte-identical to index order on the GPU and the CPU.
wf9a5m75
marked this pull request as ready for review
November 13, 2026 08:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same change as MapConductor/js-sdk-core#48 and MapConductor/android-sdk-core#46, for iOS. It's a draft because it made no measurable difference on a device.
Change
CircleTileSetwrites the geometry file in Z-order of each circle's z12 cell, using a stable radix sort of 24-bit keys. The key is the same as on the web and Android.CircleGeometryFile.record(at:)translates them.Tests:
CircleGeometryFileOrderTestsAll 560 core tests pass on the simulator.
Measured on an iPad Pro 11" (2018): 9 tiles from the real antenna set (723,800 circles), two rounds each.
No difference. The file is memory-mapped, and its 72 MB stay in the page cache, so the record order doesn't matter. It would only matter if the system evicted those pages under memory pressure, and I didn't measure that.