Repository navigation
Report camera fov and apply paddings - #21
Merged
Merged
Conversation
MKMapCamera has no padding, so the camera center is shifted with the core CameraPaddingEmulation (using MapKit's measured vertical fov, 30°) and shifted back on read; the read camera carries paddings and fov.
MapKit's scale differs slightly from the model and its pitch limit depends on altitude, so after each move (and at the end of an animation) the camera center is corrected with the map's projection, and the target is read back from the padded center.
Back-to-back setCamera calls let MapKit fold the region-change notifications, so the state kept the camera from before the correction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This provider now
MapCameraPosition.fovfor its engine, andMapCameraPosition.paddingson move / animate: the target lands at the centre of the padded area, and the camera read back reports the target with the same paddings.Depends on the core
feat/camera-paddingsPR (and, where noted, the provider's tilt fix PR).fov 30.0 (measured; pitch capped at 35); paddings emulated and corrected with the map's projection. Known: read-back can stay ~25 m off after a padded move.
Commits