Skip to content

Fix example-app lint and the core golden test - #134

Merged
wf9a5m75 merged 1 commit into
developfrom
fix/release-ci
Nov 13, 2026
Merged

wf9a5m75 merged 1 commit into
developfrom
fix/release-ci

Conversation

@wf9a5m75

Copy link
Copy Markdown
Contributor

Makes the checks on #132 (develop → main for 1.4.0) pass.

  • ktlintFormat over example-app; AntennaHorizonsPage gets explicit imports and one wrapped line by hand
  • local.defaults.properties: dummy TOMTOM/MAPTILER/LONGDO keys, so the manifest merges without secrets.properties (Android Lint step)
  • android-sdk-core → Allow a few ULPs in the zoom golden test android-sdk-core#50: the zoom golden test differed by 1 ULP on Linux x86_64; compare within 4 ULPs (test-only)

Locally: :example-app:ktlintCheck, :example-app:lint, :android-sdk-core:testDebugUnitTest all pass.

- ktlintFormat over example-app, plus explicit imports and one wrapped line
  in AntennaHorizonsPage (the parts it cannot fix itself)
- Add dummy TOMTOM/MAPTILER/LONGDO keys to local.defaults.properties so the
  manifest merges without secrets.properties (Android Lint on CI)
- Bump android-sdk-core to allow a few ULPs in the zoom golden test (core #50)
@wf9a5m75
wf9a5m75 merged commit f848de8 into develop Nov 13, 2026
1 check passed
@wf9a5m75
wf9a5m75 deleted the fix/release-ci branch November 13, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant