Repository navigation
Keep CircleController.add's id walks off the main thread - #59
Merged
Merged
Conversation
After the tiler took a list, add() filtered the list against the tiled ids and walked the previously tiled ids on the map's thread. Over the antenna sample's 723,800 tiled circles that held it for about 0.6 s per carrier toggle on a Pixel 5a. Both walks now run on Dispatchers.Default, and when every circle is tiled the filter is skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a Pixel 5a, every carrier toggle on the antenna sample (723,800 circles, all drawn as tiles) blocked the main thread for about 0.6 s.
Why
After the tiler takes a list,
CircleController.adddoes two walks on the map's thread:With hundreds of thousands of tiled circles, both are 720k hash lookups on the main thread.
What
Dispatchers.Default.Dispatchers.Default.CircleManagerkeeps its entities in aConcurrentHashMap, andaddalready registers tiled entities fromDispatchers.Default.All 451 android-sdk-core unit tests pass.
Checked
A/B on a Pixel 5a, Google Maps, antenna sample: 8 Verizon toggles, 9 s apart, on a fresh launch, two runs per build. The build was non-debuggable, with project dependencies.
onAddEnd(mean)Most of what remains is the main thread waiting on garbage collection:
WaitForGcToComplete blocked Allocfor 0.6–1.4 s. The app runs at 390–480 MB of heap with all the circles loaded.