Repository navigation
Find tapped markers when the projection rounds to whole pixels - #47
Merged
Merged
Conversation
The marker hit test measures the screen scale round the tap from points 1e-4° north and east of it. ArcGIS's 3D SceneView returns whole-pixel screen points, and zoomed out 1e-4° is under a pixel: both points landed on the tap, the scale came out 0, no search area was made, and a tap on a marker did nothing (the marker-animation sample on ArcGIS: tapping Bounce did not bounce it). The step now widens tenfold until both points are at least 4 px away, up to 1°.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping a marker on ArcGIS (3D) did nothing. It showed up in the marker-animation sample on Android: tapping the Bounce marker did not bounce it, though the Animation list button did.
Cause
searchBoundsreturned null, and the tap fell through without any error. Logged on the device: "find: no bounds".Fix
Tests
s1) and it bounces.