Repository navigation
Let the framework layer hear when overlays reach the map - #45
Merged
Merged
Conversation
OverlayAddedListeners passes each batch OverlayAddedTracker finds on the map to a listener before the onAdded calls, so that the Compose collections can count how many of their states are on the map.
Brings in GlShapeRasterizer and CircleTileFileStorage.RecordAction from the GPU tiles change, which reached develop without a dump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OverlayAddedListeners.add(listener)(@InternalMapConductorApi) passes each batch of states thatOverlayAddedTrackerfinds on the map to the listener, on the main thread, before theironAddedcalls. The batch includes states that have noonAdded. android-sdk-compose uses this foronAddStart/onAddProgress/onAddEndon the collections (MapConductor/android-sdk-compose, same branch name).With no listener registered, the tracker collects only states that have
onAdded, as before.The second commit updates the API dump with
GlShapeRasterizerandCircleTileFileStorage.RecordAction. #44 reached develop without that dump.Test:
OverlayOnAddedTestgains a listener case (9/9 pass).