Repository navigation
Project tilted cameras with the engine's field of view - #43
Merged
Merged
Conversation
WebMercatorScreenProjection gains toScreenOffset/fromScreenOffset overloads taking the camera's vertical fov. With a fov and a tilt they use the MapLibre GL JS pinhole model (camera (H/2)/tan(fov/2) from the centre, pitched by the tilt) instead of the flat similarity, which drifted further the deeper a point was: 34 px at tilt 30 and 114 px at tilt 60 near the centre, 247 px at a padded centre. A ray above the horizon gives null. The existing overloads are unchanged. Tests check the projection against an independent 3D camera at tilt 0/30/60 and several bearings, round trips, and the horizon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebMercatorScreenProjectiongainstoScreenOffset/fromScreenOffsetoverloads that take the camera's vertical fov. With a fov and a tilt they use the MapLibre GL JS pinhole model (camera at (H/2)/tan(fov/2) from the centre, pitched by the tilt) instead of the flat similarity.The flat model drifted further the deeper a point was: 34 px at tilt 30 and 114 px at tilt 60 near the centre, 247 px at a padded centre. A ray above the horizon returns null. The existing overloads are unchanged.
Tests
WebMercatorScreenProjectionTiltTestchecks the projection against an independent 3D camera at tilt 0/30/60 and several bearings, round trips, and the horizon.Merge this before the MapTiler and Longdo PRs that call the new overloads.