Repository navigation
Support bulk Circles with raster tiles - #37
Merged
Merged
Conversation
A tap on a map with tiled circles read every tiled CircleState: 0.6 s per tap on a Lenovo TB520FU at the nationwide example's 723,800 circles, on the main thread (onMapClick resolves the tap synchronously), for every tap the higher overlays did not take. The tiles already index the circles' boxes, so the tap now asks that index for the circles near it (plus in-place changes not yet redrawn) and decides on their states exactly as before: 0.1-2.6 ms. The same change as ios-sdk-core's; js-sdk-core gets it too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the bulk Circles rollout for Android, iOS, and React Web. This component is reviewed together with its SDK integration PR.
The rollout registers collections of circle states, routes eligible large collections through the shared raster tile layer, and keeps original circle states for taps and lifecycle callbacks. Large drawing models are stored in a platform cache and carrier filters reuse existing geometry where possible.
Please review and merge the relevant core and bindings changes before advancing the parent SDK's submodule pins. The parent PR records the integrated test results and links the full dependency set.