Repository navigation
Hand Circles' list over as it is while it is the only writer - #20
Merged
Merged
Conversation
Circles merged its list into a copy of the collector's persistent map at every change: removing the 147k circles of one carrier and putting back 576k took about 1.8 s in the antenna sample on a Pixel 5a. While the published membership is still the list this Circles() published last (or there is nothing yet), and the ids are distinct, it now publishes an OverlayStateList of its list instead. Otherwise it merges as before, so several Circles()/Circle() still share a collector. Needs android-sdk-core's OverlayStateList.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs MapConductor/android-sdk-core#57 (stacked on #56 and #54), which adds
OverlayStateList. Merge after that.Why
Circlesmerged its list into a copy of the collector's persistent map at every change. In the antenna sample on a Pixel 5a, removing one carrier's 147k circles and putting back 576k took about 1.8 s, before the collector and overlay walked that map again.What
While the published membership is still the list this
Circles()published last (or there is nothing yet), and the ids of the new list are distinct, it publishes anOverlayStateListof its list. The list is copied once withtoList(). Otherwise it merges into a copy of the map as before, so severalCircles()/Circle()still share one collector. On dispose, if its list is still the published one, the membership becomes empty without building a map.Measured (with android-sdk-core#57, carrier toggle, Pixel 5a, 3 runs)
Circleseffect to published: 3.6–6.0 s → 0.74–0.80 sChecked
:android-sdk-compose:testDebugUnitTest: 19 pass.apiCheckpasses.