Repository navigation
Update TomTom Maps SDK to 2.7.2 - #21
Merged
Merged
Conversation
2.7 makes MapOptions.initialCameraOptions required. Pass a minimum-zoom camera at the target position and keep moving to the real camera after the view attaches: handing over the real camera up front leaves that moveCamera with nothing to change, and with renderToTexture the first frame is then never drawn (black map on a Pixel 5a).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tomtomMapsfrom 2.6.3 to 2.7.2. 2.7.3 is not on the public TomTom Maven repository (401), 2.7.2 is the newest one there.MapOptions.initialCameraOptionsrequired.TomTomMapViewpasses a minimum-zoom camera at the target position and still moves to the real camera once the view is attached.Why not pass the real camera
With the real camera as the initial one, the existing
moveCameraafter attach changes nothing, and withrenderToTexture = truethe first frame is never drawn: the map stays black until the user pans. Starting from a different camera makes that move redraw, which is how 2.6.3 behaved (it started from its own default camera).Verification (Pixel 5a, sample-app)
renderToTexture = false: map shown (confirms it is the texture path).assembleReleaseandtestDebugUnitTestpass.