Repository navigation
Conversation
* Make bearing a clockwise map rotation bearing を「値を増やすと地図が時計回りに回る」向きに統一し、ネイティブ SDK との変換をコアの CameraBearing に集約する。 * ci: build the core module from the matching branch コアの未マージ/未リリースな変更に追随する PR を、コアが先に取り込まれるのを待たずに検証できるようにする。同名ブランチが無ければ従来どおり既定のコアを使う。 * fix: point material3 at its own version line material3 は compose-ui とは別のバージョン系列で、composeLibs(1.7.8)を流用すると存在しない material3:1.7.8 を要求して sample-app のクラスパスごと解決に失敗する。集約ビルド(android-sdk)の catalog と同じ 1.4.0 に合わせる。
MarkerTilingOptions.declutterPx existed and samples set it, but every controller dropped it on the floor when constructing MarkerTileRenderer, so the renderer ran with 0 and drew every marker on every tile. On a slow device that is the difference between an overview tile costing 538ms and 79ms (SO-02L, 144k markers, z10, MarkerTileRenderBenchmark) -- and the drawn result now actually matches what iOS and react show for the same options.
Observed once on device (SO-02L, street trees at z16, offline): the
marker tile raster layer loaded its initial viewport and then never
requested another tile -- not on pan, not after connectivity returned --
while the base layer kept requesting. The seam of the initially loaded
tiles shows as markers cut in half against blank ground, which is what
the report 'icons are cut when the base tiles are hidden' turned out
to be. Renderer and server are exonerated: an on-device test renders
360 adjacent-tile seams pixel-identical, and in healthy sessions every
getTileUrl call reaches the server 1:1.
Twelve relaunches (fresh install, offline, rotation) did not reproduce
it, so the trigger is still unknown -- likely a camera-listener
registration race inside the native tiled source. This trace is the
tool for next time:
adb shell setprop log.tag.OmmTileConfig VERBOSE
If a pan produces no getTileUrl for the marker layer while design-osm
keeps logging, the native layer stopped tracking the camera; if
getTileUrl fires but LocalTileServer logs nothing, the loader ate it.
An empty template means no design layer is added, so only what the app adds is drawn.
* feat: integrate vector style support and pending map fixes * Keep each file's line endings as they are on develop The checkpoint commit rewrote whole files between LF and CRLF, which buried its real changes under line-ending noise. Content is unchanged.
Same change as android-for-maplibre: relabelling street trees changes a few dozen tiled markers at once, and each update() replaced the raster source, so the map fetched every visible tile again per marker (on MapLibre, Pixel 5a: 45 replacements, 494 tile renders, last tile 6.1 s after the change). - Changes arriving within a frame share one tile refresh; a pending refresh is cancelled on destroy() so it cannot register the tile route again. - The tiling check reads the entity count without copying all entities. - The icon is baked only when the marker is drawn natively. - onPostProcess runs only when a native marker became tiled (it copies every entity to redraw the native ones).
OpenMobileMaps picks the floored level, so at 17.75 the marker tile layer showed z17 stretched by 1.68x, and street-tree icons and labels came out twice as large as on MapLibre, Mapbox, HERE and ArcGIS, which show z18 at 0.84x. Raster overlays now switch levels half a step early (zoom level scale factor sqrt 2), which makes the pick round to the nearest level. The base map keeps the default.
Redraw tiles once per burst of tiled-marker changes
Show raster overlays at the rounded camera zoom
OpenMobileMapsMapViewSaver dropped attributionRules. Adds a device round-trip test.
Keep design attribution rules across configuration changes
The polygon controller gets a PolygonTiler, whose tiles are shown through the raster layer path the marker tiles use (upsert / removeById, outside the app's RasterLayer composition). Tiled polygons stay registered for taps and give the map SDK nothing. The polygon renderer skips tiled entities, which have no native polygon.
registerLifecycle() adds the MapView to the Activity's lifecycle and the SDK's onDestroy() does not remove it, so the Activity kept every map the user switched away from. It is now removed from the lifecycle, paused and destroyed through MapViewBase's onDestroyMapView, once.
The touch handler holds the listener through a JNI global reference, so every controller (with its overlays) stayed in the process after its map was gone.
The state kept its own controller field, set on attach and never cleared, so a state the app keeps held the destroyed controller and every overlay of the old map. It now reads the base's attached controller, which MapViewBase detaches when the map is torn down.
Release the map view and the controller when the map leaves the composition
Markers drawn through a StrategyMarkerController (clustering and other extension modules register these with registerOverlayController) were left on the map by clearOverlays(), which only cleared this provider's own controllers. Call BaseMapViewController.clearStrategyMarkerControllers(). Needs android-sdk-core with clearStrategyMarkerControllers() (fix/clear-strategy).
Rasters and ground images shared one index range filled from freed indices, so their order followed add/re-send order; marker tiles were in the same range, below polygons. Rasters, ground images and marker tiles now get separate index bands (raster < ground image < polygon/circle/polyline < marker tiles < icons). Polygons, circles and polylines are handed to their layer in zIndex order. Stacking order (all providers, all platforms), bottom to top: raster layers < ground images < polygons < circles < polylines < markers. Needs android-sdk-core with OverlayStacking (fix/overlay-stacking-order).
Clear strategy markers in clearOverlays()
Give rasters, ground images and marker tiles their own index bands
The polygon fill redraw keeps develop's zIndex order and leaves out tiled polygons. The polygon tiles get a layer index band of their own, between the ground images and the polygon fill.
Additions only: the polygon tiles' stacking key, and declarations develop added without running apiDump (TILE_REFRESH_COALESCE, and on ArcGIS the marker controller's constructor that takes a boolean).
Draw large polygon sets as raster tiles (PolygonTiler)
The polyline controller gets a PolylineTiler, shown through the same raster layer path as the polygon tiles. A layer index band between the circles and the native polyline layer (moved up to make room). Whatever redraws from the polyline manager skips tiled entities (no native line).
Draw large polyline sets as raster tiles (PolylineTiler)
Support bulk Circles with raster tiles
The icon layer draws later entries on top, and the list followed the manager (add order). It is now sorted by zIndex, then south and west.
Same-zIndex markers follow the screen position (lower in front) and are re-sorted after rotation settles.
Stack markers by the shared draw order
The SDK padding setters are not used: they shift the view at once and do not follow the frame-stepped animation. Paddings are emulated by moving the camera center (every animation frame uses the new padding, and the start point is read with it so the first frame does not jump) and undone on read. The tilt is drawn by rotating the view with almost no perspective (spacing within 0.3% of cos(tilt)), so fov is 0.
Report camera fov and apply paddings
Release 1.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge develop into main for the 1.4.0 release.