Repository navigation
Pass the camera's field of view to the screen projection - #23
Merged
Merged
Conversation
toScreenOffset / fromScreenOffsetSync ignored tilt, so InfoBubbles, marker animations and tile-marker hit tests drifted on a tilted map (up to 114 px from the engine's own project() at tilt 60 near the centre, 247 px at a padded centre). With the fov they match the engine within 0.4 px at tilt 0/30/60 and bearing 0/±90 on the TB520FU. Needs android-sdk-core fix/screen-projection-tilt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MapTilerMapViewHolder.toScreenOffset/fromScreenOffsetnow pass the camera's fov toWebMercatorScreenProjection, so points on a tilted map land where the map draws them.Depends on MapConductor/android-sdk-core
fix/screen-projection-tilt; merge that first.