Repository navigation
Report camera fov and apply paddings - #19
Merged
Merged
Conversation
Longdo Map API3 has no padding, so paddings are emulated by moving the camera center and undone when camera events come back. The holder's synchronous projection now centers on that moved camera, so InfoBubble and marker tracking stay aligned with padding. fov is 36.87, the MapLibre GL default the map renders with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This provider now
MapCameraPosition.fovfor its engine, andMapCameraPosition.paddingson move / animate: the target lands at the centre of the padded area, and the camera read back reports the target with the same paddings.Depends on the core
feat/camera-paddingsPR (and, where noted, the provider's tilt fix PR).fov 36.87 (MapLibre GL in a WebView; not measured directly); paddings emulated.
Commits