Repository navigation
Conversation
* Make bearing a clockwise map rotation bearing を「値を増やすと地図が時計回りに回る」向きに統一し、ネイティブ SDK との変換をコアの CameraBearing に集約する。 * ci: build the core module from the matching branch コアの未マージ/未リリースな変更に追随する PR を、コアが先に取り込まれるのを待たずに検証できるようにする。同名ブランチが無ければ従来どおり既定のコアを使う。 * fix: point material3 at its own version line material3 は compose-ui とは別のバージョン系列で、composeLibs(1.7.8)を流用すると存在しない material3:1.7.8 を要求して sample-app のクラスパスごと解決に失敗する。集約ビルド(android-sdk)の catalog と同じ 1.4.0 に合わせる。 * fix: declare material-icons-core for the sample app sample-app が Icons.AutoMirrored を使うが、material3 は material-icons を推移的に持ってこないため単体ビルドで Unresolved reference 'Icons' になる。版は compose BOM 任せで、集約ビルドの catalog と同じ形にする。
TileProviderInterface gained renderTile(request, isCancelled) as a default method in android-sdk-core, so every implementor's surface picks it up. An addition, not a break — the existing overload is untouched.
MarkerTilingOptions.declutterPx existed and samples set it, but every controller dropped it on the floor when constructing MarkerTileRenderer, so the renderer ran with 0 and drew every marker on every tile. On a slow device that is the difference between an overview tile costing 538ms and 79ms (SO-02L, 144k markers, z10, MarkerTileRenderBenchmark) -- and the drawn result now actually matches what iOS and react show for the same options.
…work fetch (#14) * Render local raster tiles without HERE network fetch * feat: integrate vector style support and pending map fixes * Keep each file's line endings as they are on develop The checkpoint commit rewrote whole files between LF and CRLF, which buried its real changes under line-ending noise. Content is unchanged.
Same change as android-for-maplibre: relabelling street trees changes a few dozen tiled markers at once, and each update() replaced the raster source, so the map fetched every visible tile again per marker (on MapLibre, Pixel 5a: 45 replacements, 494 tile renders, last tile 6.1 s after the change). - Changes arriving within a frame share one tile refresh; a pending refresh is cancelled on destroy() so it cannot register the tile route again. - The tiling check reads the entity count without copying all entities. - The icon is baked only when the marker is drawn natively. - onPostProcess runs only when a native marker became tiled (it copies every entity to redraw the native ones).
Redraw tiles once per burst of tiled-marker changes
- The controller reported its default (NormalDay) when the change listener was attached, before loadScene read the state's design, so after a rotation -- or with any initial design -- the map came up NormalDay. The controller is now seeded with the state's design first. - The saver kept only the scheme id; Custom designs lost their attribution rules. It now records whether the design was a preset. - Device round-trip test (the test APK bundles the HERE SDK).
Keep the map design across configuration changes
The polygon controller gets a PolygonTiler, whose tiles are shown through the raster layer path the marker tiles use (upsert / removeById, outside the app's RasterLayer composition). Tiled polygons stay registered for taps and give the map SDK nothing.
On a configuration change the MapView was only taken off its parent, and a provider switch did nothing at all, so each old MapView stayed alive with the controller it reaches. It is now paused and destroyed through MapViewBase's onDestroyMapView, once.
The state kept its own controller field, set on attach and never cleared, so a state the app keeps held the destroyed controller and every overlay of the old map. It now reads the base's attached controller, which MapViewBase detaches when the map is torn down.
The geodesic ring was densified with createInterpolatePoints, which only interpolates between neighbouring points, so the closing edge (last vertex -> first) of a geodesic polygon was a straight chord in both fill and outline. Use android-sdk-core's densifyGeodesicRing. geodesic=false is unchanged. Requires the android-sdk-core release that adds densifyGeodesicRing.
A geodesic=false polygon passed its raw vertices to HERE, so every edge was a straight Web Mercator segment, unlike polylines with geodesic=false (linear lat/lng interpolation), the other providers and ios-for-here. Use android-sdk-core's densifyPolygonRing for both modes; it closes the ring before densifying, so the closing edge (last vertex -> first) matches the others (it replaces the unreleased densifyGeodesicRing). Requires the android-sdk-core release that adds densifyPolygonRing.
Release the map view and the controller when the map leaves the composition
Interpolate the closing edge of polygons, geodesic or not
Markers drawn through a StrategyMarkerController (clustering and other extension modules register these with registerOverlayController) were left on the map by clearOverlays(), which only cleared this provider's own controllers. Call BaseMapViewController.clearStrategyMarkerControllers(). Needs android-sdk-core with clearStrategyMarkerControllers() (fix/clear-strategy).
Raster and ground image MapLayers had the default priority and were drawn above polygons, circles and polylines. Polygons and circles shared drawOrder 0..511. Rasters now render before the style's "route" layer and ground images before "traffic_on_route" (raster < ground image, both under map items). Map items get disjoint drawOrder bands: polygons 0..339, circles 340..679, polylines 680..1023. Marker tiles keep rendering last. Stacking order (all providers, all platforms), bottom to top: raster layers < ground images < polygons < circles < polylines < markers. Needs android-sdk-core with OverlayStacking (fix/overlay-stacking-order).
Clear strategy markers in clearOverlays()
Put rasters and ground images under map items; separate draw-order bands
With develop's OverlayStacking, a raster layer goes in the raster band, under ground images. The polygon tiles are polygons drawn as images, so they go over ground images and under circles, polylines and markers.
Additions only: the polygon tiles' stacking key, and declarations develop added without running apiDump (TILE_REFRESH_COALESCE, and on ArcGIS the marker controller's constructor that takes a boolean).
Draw large polygon sets as raster tiles (PolygonTiler)
The polyline controller gets a PolylineTiler, shown through the same raster layer path as the polygon tiles. HERE's map items are one layer, so the tiles go under them, above the polygon tiles (placed against each other by layer name). Whatever redraws from the polyline manager skips tiled entities (no native line).
Draw large polyline sets as raster tiles (PolylineTiler)
Support bulk Circles with raster tiles
drawOrder is an integer, so it uses MarkerDrawOrder.ofInt: zIndex first, then south and west. Unspecified markers in the southern hemisphere no longer outrank an explicit zIndex.
HERE ignores large drawOrder values: on the TB520FU 2849 worked and 4274 fell back to add order, so the old zIndex * 1e6 encoding let an unspecified marker cover zIndex 1. Markers are now ranked by MarkerDrawOrder and given 0..2047, re-ranked on add, change and rotation.
Stack markers by the shared draw order
The principal point is not used: it is not part of the flyTo animation and jumps when set. Paddings are emulated by moving the camera center and undone on read. HERE has no fov getter, so it is measured from the live camera: distanceToTarget times the px a sideways metre moves at the target gives the focal length (about 3550 px on TB520FU regardless of map size, orientation or density), and fov follows from the map height (44.6 in full-screen portrait, 28.6 in landscape).
Report camera fov and apply paddings
Release 1.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge develop into main for the 1.4.0 release.