Repository navigation
Fix the tedana report embedding and the walkthrough figures page - #99
Merged
Merged
Conversation
…notebook The tedana report was displayed by pasting its HTML into a cell output. Its stylesheets overrode the book theme (hiding the navigation bar), its figures pointed outside the built site, and it was confined to the width of the cell. The report and its figures are now copied into the site and shown in a full-width iframe. plot_approach_figures.md was excluded from execution because it failed. It now runs: define func_dir, use the T1w file name in ds006185, apply the inverse of the boldref-to-T1w transform, convert echo times to milliseconds, index the component weights by component, and fit the axis limits to the data. Also keep data/ and notebooks/ out of the Sphinx sources.
# Conflicts: # _config.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
plot_approach_figures): excluded from execution because it referred to an undefinedfunc_dirand a T1w file that is not in ds006185.data/nilearn/README.md,notebooks/README_notebooks.md) were picked up as book pages and raised toctree warnings.Fixes
book_utils.export_html_reportcopies the report and itsfiguresfolder tocontent/figures/html_extra/tedana_report/. That folder is served throughhtml_extra_path, and it travels to CI in the execution bundle with the rest ofcontent/figures. The page embeds the report in a full-width iframe, with a link to open it in its own tab. The report keeps its own CSS and scripts, so the book theme is untouched.make bookcreatescontent/figures/html_extrafirst, because Sphinx drops anhtml_extra_pathentry that does not exist when the build starts.plot_approach_figuresruns again and is no longer excluded: file names fixed, echo times in milliseconds, the T1w background resampled onto the BOLD grid with the coregistration transform, component maps indexed by component number, and an empty log-scale plot fixed.00_Download_Datalists the two extra files those figures need (preprocessed T1w and the boldref-to-T1w transform).data/**andnotebooks/**are excluded from the book sources.Verification
execution-cachebundle already contains the executed tedana and walkthrough-figures pages and the exported report.🤖 Generated with Claude Code