Repository navigation
Fix dual-echo denoising regression and chapter text - #100
Merged
Merged
Conversation
- Fit the short echo to the later echo (the regression direction was reversed) and keep one beta per voxel (the loop overwrote a scalar, so the last voxel's beta was applied to the whole brain). - Correct the swapped carpet plot labels and title them with echo times. - Clarify the BOLD/TE relationship, acquisition trade-offs, and that the tutorial data's first echo (14.2 ms) is not a true short echo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes correctness problems in the Dual-Echo Denoising chapter and the
regress_one_image_out_of_anotherhelper.Code (
content/book_utils.py)lstsqfit the short echo using the later echo. It now fits the short echo (nuisance) to the later echo (data), as in Bright & Murphy (2013).betas = ...replaced the array with a scalar on every loop pass, so the last voxel's beta was applied to every voxel. The fit is now vectorized, with one beta per voxel, and guards voxels with zero nuisance variance.Chapter (
content/04_Dual_Echo_Denoising.md)Other
Acquiring_Multi_Echo_Data.md: "~5ms" is now "a few milliseconds", consistent with the chapter.Testing
make booksucceeds locally; only this chapter re-executed.Note: CI renders from the published execution cache, so
make publish-cachemust be run before the deployed site picks up the new outputs.🤖 Generated with Claude Code