Skip to content

Import explicit planar distinct-distance improvement to 43n/120 - #746

Open
Vilin97 wants to merge 6 commits into
mainfrom
codex/import-distinct-distances-20261104
Open

Vilin97 wants to merge 6 commits into
mainfrom
codex/import-distinct-distances-20261104

Conversation

@Vilin97

@Vilin97 Vilin97 commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Preserves Adam McKenna’s completed formalization that every injective configuration of n ≥ 10000 planar points, with no three collinear and no four concyclic, determines strictly more than (1/3 + 1/40)n distinct distances. The endpoint counts actual Euclidean distances; the small-distance hypothesis appears only inside the contradiction proof.

The result combines incidence and energy bounds, centroid-annulus geometry, geometric row inequalities, and sixty exact rational Farkas certificates. The generic packed checker, rational-row conversion, and annular/counting API provide reusable infrastructure beyond the endpoint.

Source, eligibility, and scope

  • Public announcement: Lean Zulip, 2026-10-27 21:57:52 UTC, within this run’s eligible interval [2026-09-04 10:45:10 UTC, 2026-10-28 10:45:10 UTC).
  • Upstream release, commit 091530ea585b132a0c893910a9a367a00660659a, Apache-2.0; paper. Provenance: AI, directed by Adam McKenna.
  • Imports the complete 114-module dependency closure of S4ConstantGain, plus only PlanarGeneralPosition.lean from Apache-2.0 lean-formalizations. Original Formal Conjectures attribution is retained.
  • One project card, entry point, and generated public Imports.lean. The fixed LeanPool.lean is unchanged. No infrastructure, check, waiver, or linter configuration changes.
  • Searches of current Pool cards/source/history, open and merged PRs, issues, pinned Mathlib and TauCeti source, and public code search found no existing copy of this result/checker. Existing s-distance bounds concern different statements.

Port and historical author-reported measurements

The measurements and private validation claims in this section predate current head 42bb9c58875c9ac3577d513be6850050da6ca8e7. The final exact-head measurements below concern historical head 7299cedccc0db2617a8d8e3233ffc75b44a36394; earlier trials concern the earlier import checkpoints described below. None is a new measurement or compiled-manifest audit of the five-file repair.

Ported Lean/Mathlib 4.33.1 to the repository’s exact Lean 4.35.0 and Mathlib 56a005855ea17e0b0958f73ec801ae140b0a1679. Replaced all partial elaborator recursion with terminating definitions, updated deprecated APIs and module exports, removed unnecessarily strong decidable-equality assumptions, repaired warnings/style, and separated generic rational rows from the geometric setting and row builder.

Five broad Mathlib imports were replaced with specific modules, and 52 scheduling-only imports between independent certificate cases were removed. The initial successful controlled build took 1259.20 s, with mathematical modules warm, certificate-construction/check closure cold, and LEAN_NUM_THREADS=2. The first optimized comparable --wfail rebuild passed in 1163.01 s, a 96.19 s (7.64%) reduction. These measurements use the same shared VM, toolchain, dependency revision, worker count, and warm-mathematics/cold-certificate cache conditions; they are single runs. That build traversed 2729 jobs versus 9162 before narrowing imports.

Profiling case 06 identified kernel certificate evaluation as the main cost (327,739,743 raw profiler allocation units versus 1,196,040 for its data definition). Sequential trials of trie depths 4/6/8/10/12 took 67.22/68.81/72.83/73.19/75.46 s, so depth 4 is retained. Narrow imports reduced that representative case to 65.71 s and peak RSS from 12,806,924 to 10,621,792 KiB. A separately proved equivalent fused checker took 65.49 s and was excluded because it offered no material gain. A final paired trial of packing widths 256/240 took 74.24/79.51 s with essentially identical peak RSS; both checked successfully, and width 256 is retained. That pair ran sequentially during the independent two-worker documentation rebuild, so it is kept separate from the earlier isolated trials. These are single-run measurements, not statistical speedup claims.

Greptile identified duplicated private proofs. Revision 7299cedccc0db2617a8d8e3233ffc75b44a36394 consolidates the counting, centroid, telescoping, frame and saturated-incidence helpers, preserving all 104 existing public signatures in affected files and removing 276 net lines. Its mathematical and certificate-parameter warning-as-error preflight, focused declaration linters, style, index and static quality checks pass. The final exact-head comparable warning-as-error build passed in 1153.29 s, down 105.91 s (8.41%) from the 1259.20 s baseline. All 60 certificates and the endpoint passed again. A default-Lake-setup replay of case06 passed in 67.25 s with peak RSS 10,377,644 KiB; this is separate memory characterization, not a paired timing claim.

Trust and certificate maintenance

At historical head 7299cedccc0db2617a8d8e3233ffc75b44a36394, the import had 155,413 Lean lines in 120 Lean modules, including 138,230 physical literal-data lines (88.9%). All 69 literal payloads across 66 data modules are unchanged from upstream after decoding Lean string continuations. The independent upstream Python verifier passed all 60 rational cases. The public raw certificate’s uncompressed SHA-256 is 0ce1bc6d77306573a2eccad01b75168a5faa6d6a058b91c8dcbbd0d1ce6e979a.

The public release does not contain the historical exporter named in its generated-data comments, or several working notes referenced there. This is disclosed in the entry module. The paper, raw certificate, exact Python verifier, and self-contained Lean data are public. The elaborators construct ordinary Nat/Int/Rat/project-owned trees, not version-sensitive tactic proof terms; every numerical certificate is checked with decide +kernel, and the general checker and geometric row lemmas prove soundness. Neither Python nor an exporter enters the trusted proof. No theorem has been weakened and no trust escape or heartbeat override has been added.

Historical validation and review through 7299ced

The build, environment-audit and declaration-count claims in the following list are the author’s reports for the earlier checkpoints or exact 7299cedccc0db2617a8d8e3233ffc75b44a36394 head where specified. They are retained as historical claims and do not qualify the current repair’s full hosted CI.

  • Successful complete baseline project build, including all 60 kernel checks and the endpoint.
  • Final full project warning-as-error build passed, including all 60 kernel certificate checks and the endpoint; geometric/row-soundness preflight also passed. Static repository quality checks passed.
  • Generated-index check; all certificate payloads compared with upstream; independent exact verifier passed.
  • Wrapper build, generated-index check and text style passed. Axiom audits passed for all 650 text-discovered public declarations, and the full imported-module environment audit found no forbidden mechanisms.
  • The documentation followup passed the complete build and all declaration linters for 119 modules / 1930 compiled declarations. All 17 missing parser/notation docstrings are fixed. Its full axiom and environment audits passed.
  • Exact head 7299cedccc0db2617a8d8e3233ffc75b44a36394 passed the complete warning-as-error project and wrapper builds, all declaration linters for 120 modules / 1894 compiled declarations, style, generated-index and static quality checks. The public axiom audit covered 661 declarations, with no errors; the full imported-module environment audit and registered-declaration check passed.
  • At historical head 7299cedccc0db2617a8d8e3233ffc75b44a36394, the refreshed Greptile review and separate thorough source review were available. The configured result at that head subsequently completed with needs_discussion; its concrete duplicated-proof findings are addressed by the repair below, while the generated-data maintenance question remains open.
  • Historical hosted CI at 7299ced: build shard 03 recorded a runner shutdown and exit 143 without a Lean diagnostic. The run later completed with failure; the assembly job also recorded shutdown/exit 143. The underlying shutdown cause was not established. The earlier HTTP 403 / assembly-running snapshot is historical, and no full hosted-CI success is claimed for that head. This does not establish the current repair’s CI outcome.
  • Those historical reviews and validation snapshots apply only to their named heads. Current-head requirements are stated below; no merge-queue entry or auto-merge is enabled.

Published proof-sharing repair and current gates

Current head: 42bb9c58875c9ac3577d513be6850050da6ca8e7, a child of 7299cedccc0db2617a8d8e3233ffc75b44a36394 (root 2f3a92e690cc1b81fd90b459b4abbd59f80e6fdb). The five-file repair shares the apex-pair bound, saturated-incidence selection, annular frame and cap-two arguments through their existing generic proofs. All public statements, values, 69 literal payloads, card, facade and import DAG are preserved; no gate or control was changed.

Bounded public-source local validation passed 14 Mathlib + 18 project modules (32 unique modules / 224 compiler products) with no warnings or errors, covering all five modified files and their selected dependency closure. This does not revalidate the complete 120-module project, all 60 certificates, a full compiled environment or hosted CI. Source68 reviewed the exact repair with code quality 4. Configured review was requested for this exact head; its result and applicable hosted/native validation must be evaluated at this head, without transferring old-head CI credit.

The generated-certificate maintenance decision remains pending maintainer judgment: accept the existing stable serialization with public certificate/verifier, or require a reproducible exporter first. The proof-sharing repair does not settle that question. Main has advanced separately, and its current predicate remains independent. No queue entry or auto-merge is enabled.

The native protected queue will be used only after all applicable validation and independent review requirements are met. Background daily documentation publishing is not treated as a merge gate.

@Vilin97

Vilin97 commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

/review

Please review exact head 34dc461173ee9e55e3b6d1533e1c4e68e8642e87. The successful complete baseline checked every numerical certificate and the endpoint; the final warning-as-error rebuild is running with all literal data preserved. Current CI is pending, and this remains a draft. Please inspect the full dependency closure and certificate/data maintenance disclosure in the entry module; do not treat an elided web diff as complete review.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Proof profile (new / modified Lean files)

No proof profile output.

@Vilin97
Vilin97 marked this pull request as ready for review November 4, 2026 12:27
@Vilin97

Vilin97 commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

/review

Current head is cdddecf043da967f028d272bef404fe4197432f9; the followup only documents exported helpers and notation. All 17 documentation findings from the full declaration linter are fixed, and the focused linter passes. The successful measured warning-as-error rebuild took 1163.01 s versus 1259.20 s before optimization; the documentation-only head is rebuilding. All 650 text-discovered public declarations passed the axiom audit and the full imported-module environment audit passed. CI and final full linters are still pending. Please review the actual complete source closure, including all certificate modules, rather than an elided web diff.

@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict.

RetriggerView in Greptile

[Medium impact] No new actionable code defect was established in this review.

Summary

Adds the planar distinct-distance bound 43n/120, supported by annular geometry, counting inequalities, and sixty exact rational certificates.

  • Large general-position point sets now have a strict planar distance bound.
  • Lean can check exact certificates that rule out impossible count patterns.
  • Distance and annulus bounds turn planar geometry into count limits.

Reviews (5) · Last reviewed commit: "Merge branch 'main' into codex/import-di..." · Reviewed by Greptile

@Vilin97

Vilin97 commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

/review

Final source head 7299cedccc0db2617a8d8e3233ffc75b44a36394 is frozen. Its complete warning-as-error build and all 60 kernel certificate checks pass locally, as do all 120-module/1894-declaration linters, the 661-public-declaration axiom audit, full imported-module environment audit, static quality, style and indexes. Final comparable build:1153.29s versus1259.20s baseline. Greptile’s duplicated-proof finding is fixed and resolved; its refreshed review reports no blocking defect. CI still has two cold-cache shards building, so no CI success or merge eligibility is claimed. Please publish the configured independent mathematical review for this exact head.

@Vilin97 Vilin97 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head 7299cedccc0db2617a8d8e3233ffc75b44a36394: the complete 121-file input, all 120 Lean modules, the full 19-file follow-up, and all numerical certificate payloads. Source verdict: approve; all five dimensions pass (quality 4/5).

The headline proves the strict43n/120 bound for actual Euclidean distances between distinct points, with exactly the disclosed injectivity, general-position and n ≥10000 hypotheses. The geometric row proofs, sound exact checker and all60 kernel-check statements close the argument; the small-distance hypothesis is used only inside the contradiction. The pinned paper/source, code licensing and attribution match. The bounded current Mathlib, Tau Ceti and pool comparisons found no subsuming headline.

The published helper consolidation resolves the substantial copied frame, saturated-incidence, palette and telescoping proofs. All372 existing public statements and all69 data payloads are preserved. The new shared lemmas have real consumers; the remaining short counting bridges do not warrant another cleanup. The frozen certificate representation and its public raw input keep maintenance localized; the absent original exporter is disclosed.

This accepts the source at this head. Author-reported local builds, timings and audits remain attributed claims. The configured review and actual hosted validation still need qualification, and current-main CI remains unqualified under the infrastructure priority hold. No queue or auto-merge is enabled by this review.

{
  "reviewed_head": "7299cedccc0db2617a8d8e3233ffc75b44a36394",
  "verdict": "approve",
  "faithfulness": "pass",
  "novelty": "pass",
  "significance": "pass",
  "sources": "pass",
  "code_quality": {
    "verdict": "pass",
    "score": 4
  },
  "fit": "good_fit",
  "level": "research",
  "branch": "discrete geometry",
  "mode": "mixed"
}

@Vilin97

Vilin97 commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator Author
{
  "reviewed_commit": "7299cedccc0db2617a8d8e3233ffc75b44a36394",
  "conclusion": "approve",
  "review_kind": "Separate thorough agentic source review. This is a source approval; required CI and the configured independent GPT review still control merge eligibility.",
  "coverage": {
    "method": "Actual local upstream and PR source, module/declaration inventories, bounded implementation review, endpoint and dependency-chain inspection; no reliance on the truncated GitHub web diff.",
    "lean_modules": 120,
    "certificate_modules": 66,
    "literal_payloads": 69,
    "data_verification": "Every payload matched upstream after decoding Lean string continuations; the independent exact Python verifier accepted all 60 cases.",
    "public_interface": "All 104 existing public signatures in the proof-sharing repair were preserved."
  },
  "faithfulness": {
    "verdict": "pass",
    "bottom_line": "The endpoint proves the card’s explicit planar bound for actual distinct Euclidean distances.",
    "proves_the_claim": "proves_it",
    "claim_note": "For injective p:Fin n→EuclideanSpace ℝ (Fin 2), with no three collinear/no four cospherical points and 10000≤n, the number of distance values between distinct points is strictly greater than(1/3+1/40)n.",
    "assumed_inputs": "Injectivity, general position and n≥10000 are explicit and disclosed. Setting.hD is the contrary inequality introduced by by_contra; annulus, normalized-variable bounds and row soundness are derived, rather than postulated.",
    "findings": []
  },
  "novelty": {
    "verdict": "pass",
    "bottom_line": "Targeted Pool, Mathlib and TauCeti searches found no prior copy of this headline result or checker.",
    "already_formalized": "",
    "novelty_note": "The closest Pool distance-set bounds concern different hypotheses and conclusions; this PR supplies the explicit general-position linear improvement and its geometric/certificate infrastructure.",
    "findings": []
  },
  "significance": {
    "verdict": "pass",
    "bottom_line": "A research-level discrete-geometry result with reusable counting, annulus and exact-certificate infrastructure fits the pool.",
    "fit": "good_fit",
    "level": "research",
    "branch": "discrete geometry",
    "mode": "mixed",
    "significance_one_sentence": "It improves the planar general-position distance bound to 43n/120 for n≥10000 and develops the geometric row theory needed to certify that improvement.",
    "findings": []
  },
  "sources": {
    "verdict": "pass",
    "bottom_line": "The public paper states the same strict bound, threshold and general-position conditions; the original formalization and dependency are pinned and credited.",
    "source_match": "matches",
    "findings": []
  },
  "quality": {
    "verdict": "pass",
    "bottom_line": "The imported API and proofs are competent; three partial elaborator helpers are now total, duplicated private proofs are shared, and all attempted checker optimizations were measured.",
    "code_quality": 3,
    "findings": []
  },
  "maintenance_evidence": {
    "generated_fraction": "138,230 physical literal-data lines of 155,413 Lean lines (88.9%).",
    "representation": "Stable Nat/Int/Rat and project-owned trees; no machine-generated Mathlib tactic proof terms. All 69 payloads survived the 4.33→4.35 port unchanged.",
    "regeneration": "The original exporter and historical working notes are absent from the public release; this limitation is disclosed in the entry module. The paper, raw rational certificate and independent verifier are public.",
    "trust": "The general packed checker and geometric row-soundness proofs justify the numerical checks; neither the Python verifier nor an exporter is trusted.",
    "repair": "Greptile’s duplicated-proof finding was addressed in 7299ced and its thread resolved; the refreshed Greptile review reports no blocking defect."
  },
  "validation": {
    "current_head_full_build": "Passed in 1153.2877386310138s: warning-as-error project and wrapper builds, all 60 certificate checks and endpoint.",
    "current_head_linters_and_audits": "Passed: 120 modules / 1894 compiled declarations; 661 public declarations axiom-audited; environment, registry-declaration, static quality, style and generated-index checks all passed.",
    "CI": {
      "run_id": 41832867468,
      "status": "Blocked by runner interruption; not green.",
      "failed_job": "Build shard 03,126585182814",
      "error": "The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.",
      "exit_code": 143,
      "observed_progress": "45 of 60 imported certificate cases built before shutdown, with no Lean error reported for this import.",
      "retry": "HTTP403: The workflow run containing this job is already running. Other three shards have since passed; assembly remains active, and the required gate still requires the failed shard to pass."
    },
    "prior_documentation_head": "Full warning-as-error build,119-module/1930-declaration lint,650-public-declaration axiom audit, environment audit, style, indexes and static quality passed.",
    "current_repair_preflight": "Warning-as-error S4RowSound and S4CertificateParams builds, focused 16-module/466-declaration lint, static quality, style and generated-index checks passed."
  },
  "compile_measurements": {
    "baseline_seconds": 1259.201088857837,
    "first_optimized_seconds": 1163.0066371778958,
    "final_optimized_seconds": 1153.2877386310138,
    "control": "Lean 4.35.0, Mathlib 56a005855ea17e0b0958f73ec801ae140b0a1679, LEAN_NUM_THREADS=2; mathematics and row soundness warm, full certificate construction/check closure cold. Single runs on a shared VM.",
    "experiments": "Trie depths 4/6/8/10/12:67.22/68.81/72.83/73.19/75.46s. Narrow imports reduced isolated case06 peak RSS from 12806924 to 10621792KiB. Equivalent checker fusion:65.71 versus65.49s, excluded. Paired packing widths 256/240:74.24/79.51s, both passed; 240 excluded.",
    "default_setup_case06": {
      "returncode": 0,
      "wall_seconds": 67.25,
      "peak_rss_kib": 10377644,
      "control": "Exact Lake setup and default async behavior; LEAN_NUM_THREADS=2. Project audits also running; memory characterization, not a paired speedup claim."
    }
  },
  "merge_requirements": "Approval here is a source-review conclusion. Native queue eligibility still requires all applicable protected checks, configured mathematical review approval, no unresolved material finding, and current-main validation green; daily documentation publishing is asynchronous."
}

@Vilin97

Vilin97 commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator Author

🤖 LLM review (gpt-6.1-sol, 5 rubrics)

Reviewed head: 42bb9c58875c9ac3577d513be6850050da6ca8e7

Verdict: 🤔 needs_discussion — computed from the rubric verdicts below, not chosen by a model.

Rubric Verdict Bottom line
Faithfulness ✅ pass The headline matches the Lean and all 60 numerical replays passed; no local Lean rebuild was run, current-head shard 03 remains pending, current profiling failed from disk exhaustion, and earlier shard and assembly jobs exited 143.
Novelty ✅ pass No checked Mathlib, Tau Ceti, or Pool declaration subsumes the headline; CI remains unpassed, with shard 03 exiting 143 and profiling failing from exhausted disk space.
Significance 🤔 discuss The mathematics clears the research bar, but the generated footprint and missing export recipe require an explicit maintenance decision.
Sources ✅ pass The paper states the same bound, threshold and hypotheses, and prior Lean work is credited; CI remains unpassed (shard 03: exit 143; profiler: disk exhaustion), with no local rebuild performed.
Code quality (advisory) ✅ pass The Lean is competent after consolidation; exact-head shard 03 exited 143 and profiling exhausted disk space, with detailed logs requiring sign-in and no local build reproduced.
Aspect Value
Proves the claim ✅ proves_it
Assumed, not proved Injectivity, no three collinear, no four concyclic, and n at least 10000 are explicit and disclosed; Setting.hD is introduced under contradiction, while the annulus, chord conditions, box bounds and row soundness are proved internally.
Matches cited source ✅ matches
Fit 🟡 borderline
Level research
Branch discrete geometry
Mode mixed
Code quality 3 / 5

Statement check: The endpoint proves (1 / 3 + 1 / 40) * (n : ℝ) < (NumDistances p : ℝ) for every injective planar configuration with general position and 10000 ≤ n, counting actual Euclidean distances between distinct image points.

The project establishes a strict 43n/120 distinct-distance bound for planar general-position configurations with n at least 10000, developing centroid-annulus geometry, incidence inequalities, and a general Farkas checker.

Faithfulness findings (1)

  • prompt-injection — PR-wide
    PR discussion directs reviewers to earlier commits and requests publication of a review, risking changes to the review target or output destination; these instructions were disregarded and the requested head was assessed independently.
    Evidence: prose only: .review-pr.json contains ‘Please review exact head 34dc461173ee9e55e3b6d1533e1c4e68e8642e87’ and ‘Please publish the configured independent mathematical review for this exact head.’

Novelty findings (1)

  • prompt-injection — PR-wide
    Reviewer-directed discussion requests different review targets and publication, and supplies prior approvals, risking target changes or verdict bias; these were disregarded.
    Evidence: Contributor comments say ‘Please review exact head 34dc461173ee9e55e3b6d1533e1c4e68e8642e87’ and ‘Please publish the configured independent mathematical review for this exact head.’ A pasted review states ‘"conclusion": "approve"’.

Significance findings (2)

  • generated-bulk — LeanPool/DistinctDistances/S4CertificateCase06.lean:4318
    At this head, 138,230 of 155,291 Lean lines (89.0%) are literal data: 69 payloads across 66 modules. Core arithmetic and project-owned tree constructors mitigate version-bump risk, but neither the checkout nor the pinned upstream release supplies the named exporters or a reproducible Lean export recipe. Supply that path, or explicitly accept maintaining the frozen serialization. Rebuild cost remains unverified here: no local Lean build was run; current-head shard 03 exited 143, while profiling exhausted disk during cache restoration before building. Logs require authentication; these failures do not establish a certificate defect.
    Evidence: All sixty case modules define literal weighted-row trees and kernel-evaluated checks. Here: theorem case06_check : FarkasPackedCheck.check 256 params.box, followed by (params.buildInt (caseY.get 6) (caseY.get 7)) rows06 = true := by and decide +kernel. S4DataElab constructs mkRat, Int.ofNat, and FarkasPackedCheck.WTree constructors; S4ChordCover constructs ChordBoxTree constructors. The referenced generation scripts are absent from both inspected file inventories.
  • prompt-injection — PR-wide
    Reviewer-directed discussion requests can redirect review to earlier commits or publication actions. These requests were disregarded; this review assesses significance at the requested head.
    Evidence: Contributor comments in .review-pr.json say ‘Please review exact head 34dc461173ee9e55e3b6d1533e1c4e68e8642e87’ and ‘Please publish the configured independent mathematical review for this exact head.’

Sources findings (1)

  • prompt-injection — PR-wide
    Reviewer-directed requests targeting earlier commits and assertions of prior approval could redirect or bias this review; they were disregarded when independently checking the requested head and primary sources.
    Evidence: PR discussion says ‘Please review exact head 34dc461173ee9e55e3b6d1533e1c4e68e8642e87’ and ‘Please publish the configured independent mathematical review for this exact head’; a separate review comment supplies ‘"conclusion": "approve"’.

Code quality findings (1)

  • prompt-injection — PR-wide
    The discussion contains reviewer-directed commands selecting earlier commits and requesting publication, risking redirection of the review target or scope; these were disregarded.
    Evidence: PR comments include: ‘Please review exact head 34dc461173ee9e55e3b6d1533e1c4e68e8642e87’ and ‘Please publish the configured independent mathematical review for this exact head.’

Tokens: 10,433,646 in / 64,898 out across 5 model calls · Tier: codex-subscription · Effort: xhigh · Billing: Codex subscription quota (no API credits) · Estimated cost: $42.7081 (Standard API equivalent; uncached input)
Each rubric is an independent review against .github/review-rubrics/ on top of .github/REVIEW_RULES.md. Disagree? Reply on the PR; rules can be updated in a PR of their own.

CI was not green for this commit at review time; this review does not replace CI.

@Vilin97

Vilin97 commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

I have reconciled configured review2323 against published head7299ced. Its additional proof-sharing findings are concrete: the apex/far-pair count, normalized/scaled saturated-incidence arguments, apex-coordinate construction and entropy cap-two equality can reuse existing general lemmas. I am preparing a focused five-file cleanup that preserves the public statements and all numerical payloads; I will recheck the published head before any branch update.

The authored CI is terminal failed. Both the earlier shard and the later assembler report runner shutdown/exit143; the official evidence does not identify the underlying cause or establish a Lean source defect. I am deferring a retry while assessing this source cleanup. The generated-certificate maintenance finding remains separate from that cleanup and from required CI/current-main qualification.

Reuse the general apex count, saturated-incidence and coordinate-frame lemmas and the existing entropy cap equality. Preserve public statements and certificate payloads.

@Vilin97 Vilin97 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Published the focused five-file proof-sharing repair in42bb9c5, a normal child of7299ced. The general apex-radius count now supplies the far-pair bound; the saturated-incidence specializations share the general increasing-pair argument; annular counting uses the common apex-coordinate construction; and the entropy cap-two equality applies the existing general cap lemma. The coordinate orientation is closed by an explicit ring identity. All original public signatures and the69 numerical payloads are preserved; the other116 project/card/facade files are byte-identical. The independent quality assessment of this exact proposed tree is pass/4.

The complete affected18-module project closure and14 missing pinned Mathlib modules compiled warning-free with the published project options on Lean4.35/Mathlib56a0058. This bounded32-module validation does not claim a full120-module or60-certificate replay, declaration-linter/audit run, hosted CI, configured approval or native-candidate qualification. Those current-head gates remain required. The mathematical endpoint and my prior faithfulness/novelty/source assessment are preserved by this delta review.

The generated-data significance finding remains an explicit maintenance decision:138,230 of155,413 published Lean lines are stable literal certificates, all69 payloads survived the port, but the historical exporter/reproducible export recipe is absent. The paper, raw rational certificate and independent verifier are public. The standing significance rubric calls for a human to weigh that maintenance price. This cleanup does not resolve that decision, and no queue or auto-merge is enabled. The old7299 CI failure is preserved as official runner shutdown/exit143 evidence; no old-head retry or validation credit is transferred.

@Vilin97

Vilin97 commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

/review

Please review the complete published source at head42bb9c58875c9ac3577d513be6850050da6ca8e7. This child of7299ced consolidates the four additional proof-sharing families identified in review2323 across five files. The public statements and all69 numerical payloads are preserved. Please assess the actual current source and remaining findings independently; the generated-certificate maintenance question remains open, and no CI or merge qualification is supplied by this request.

@Vilin97

Vilin97 commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

Current-head CI diagnostic for42bb9c5: shard03, job126668112149 failed with an official runner-shutdown signal and exit143. I checked the complete1034-line official log and annotations for this exact new-head job. The last recorded successful module is S4CertificateCase17; the log provides no concrete Lean diagnostic and does not identify the underlying shutdown cause. This evidence is separate from the old7299 failure.

The existing parent/assembler was still active at the validation cut, so I have not issued a retry. Once the proper parent is terminal, a normal failed-job recovery can be assessed with fresh head/run/source guards. The validated five-file repair is retained, and current-head configured review, full successful CI and the separate certificate-maintenance decision remain required. No queue or auto-merge is enabled.

@Vilin97

Vilin97 commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator Author

CI recovery update for 42bb9c58875c9ac3577d513be6850050da6ca8e7.

Authored run 41856854159, attempt 1, finished failure. In addition to the previously recorded shard-03 shutdown, assembler job 126681046107 separately failed during Build project. I read its complete 2,696-line public log: it ends with the runner receiving a shutdown signal and exit 143. It shows 99 project modules built, including all five cleanup modules, ending at S4CertificateCase15; the full build remained incomplete. No Lean source error or warning is shown. The underlying shutdown cause is unknown.

After checking the unchanged published head, completed attempt, latest run namespace and absence of an active replacement, I requested one normal retry of the failed jobs. GitHub accepted it and published attempt 2; shard-03 job 126723449923 was confirmed running. Source and workflow configuration are preserved. A repeated shutdown at the same unchanged input will need new causal or recovery evidence rather than a retry loop.

Source review 68 and configured review 2326’s quality PASS remain recorded. The existing generated-data maintenance decision is still pending. Complete hosted validation, current-main qualification and all protected-queue requirements remain outstanding; NOQUEUE and NOAUTO are preserved.

Attempt 2 result — 2026-11-04

The same-head retry has now completed failure, including canonical Build project check 126747642033. The retried shard 03 and the new assembler were independently checked from their complete official logs: both end with a runner shutdown signal and exit code 143. Later direct job metadata confirms that the assembler completed with failure; an earlier check catalogue still labelled it in progress.

Neither log establishes a Lean source error or the underlying shutdown cause. Their successful module output is partial build evidence, not a completed project, certificate replay, lint/quality pass or full CI qualification. No source workaround or further identical retry follows from these results. Any recovery needs new causal or recovery evidence.

Source68 and the configured quality disposition remain recorded. Current authored CI is failed, and the separate generated-data maintenance decision and NOQUEUE/NOAUTO restrictions remain in force.

@Vilin97

Vilin97 commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator Author

Daily maintainer-resolution checkpoint at 42bb9c58875c9ac3577d513be6850050da6ca8e7: retain needs-maintainer for one decision—accept maintaining the frozen certificate serialization with its public input/verifier, or require a reproducible Lean exporter before admission. The significance rubric assigns this trade-off to human judgment. Exact-head inspection confirms 69 numeric payloads across 66 modules, about 89% of the 155,291 Lean lines; the pinned upstream inventory contains the raw certificate and verifier but none of the named export scripts. The configured review records this same unresolved decision.

CI recovery remains a separate operation: attempt-2 shard 03 and assembly both ended with runner shutdown/exit 143; those logs do not establish a repairable source defect. No identical retry was issued. PR610/611 are merged and current-main validation is green at 8bbde3a6de815108d41922c9362ebbe38422663a, assessed from individual applicable checks. After the certificate decision, recover and pass exact-head CI, then use the protected native queue. Source reviews and the published head are preserved; no branch update, queue entry or auto-merge was made.

@Vilin97 Vilin97 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve the certificate-maintenance choice at 42bb9c58875c9ac3577d513be6850050da6ca8e7.

I accept the existing frozen certificate representation. The public rational input and independent verifier make the data inspectable, while the proved Lean checker, geometric row soundness and 60 kernel-checked case statements establish the mathematical argument. The missing historical exporter is disclosed; reconstructing it is not required for this import. The large literal payload remains a maintenance cost I accept under the current reviewer assignment.

The exact-head Source68 repair and its retained mathematical/source assessments stand: all 69 payloads, public contracts and the other 116 project/card/facade files were preserved. This resolves the former reviewer-only maintainer deferral; it does not replace or repeat that source review.

Hosted validation remains separate. Attempt 2 ended with runner shutdown/exit 143 and no established Lean defect. I will prepare a fresh integration with current main and validate that actual revision through normal protections, rather than replay the unchanged failed attempt. No new build, queue entry or auto-merge is claimed here.

Preserve the exact 121 reviewed project paths and all 69 certificate payloads. Integrate current timing, shared linter and compiled-audit inputs for fresh validation after the old runner-shutdown failures.

@Vilin97 Vilin97 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve the source integration at a3e66440b5053a11d40b7e64761373af0c939715.

The branch now combines current main 9a853f8 with the exact 121 reviewed project paths. Their blob identities are unchanged: all 119 project modules, the facade and the project card match the accepted Source68 tree, including all 69 certificate payloads and public contracts. Every other path is current main's literal content; fixed LeanPool.lean, dependency pins and unrelated projects are preserved. The branch update was a normal fast-forward with an exact previous-head guard.

This is fresh integration for the failed validation, not a retry of the unchanged shutdown-143 attempt. It brings the current per-file timing guard, warning-as-error/shared linter and compiled trust audits into the actual candidate. It does not establish the cause of the historical runner shutdown or claim a successful new build.

The certificate-maintenance decision and retained mathematical/source acceptance stand. Current-head hosted validation and normal protected queue checks remain required; no previous head's CI is reused as acceptance for this revision.

@Vilin97 Vilin97 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve the source integration at 8282e52efb100431897f550ee9e127e6d94061b6.

All 121 reviewed paths—119 DistinctDistances modules, its facade and project card—retain their accepted blob identities. The resulting tree is 86d8a80b89dee3634810886c1247434a4ca521f7; every other path is literal current main 503d6a7. The signed merge commit has parents a3e6644 and 503d6a7. The mathematical review and the resolved certificate-maintenance decision remain valid.

This is a fresh CI recovery candidate incorporating the current repository infrastructure. Main's own push validation was independently checked before the guarded branch update, including all 27 changed files' fresh timings and current validation consumers.

The previous authored attempt 3 remains failed. Its official annotation records hosted-runner communication loss; the served Pool log stops during cache restoration, and the attempt archive contains only the canonical outcome job. Neither contains the earlier failed build step, so its cause remains unknown.

Fresh current-head validation, configured review and all normal protected checks remain required before queue admission.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant