There is no rust-toolchain.toml in the repo, and CI installs dtolnay/rust-toolchain@stable (.github/workflows/build.yml:177), so every checkout formats with whatever stable it happens to have.
It already bites: cargo fmt --check flags lnvps_api_common/src/exchange.rs:621 on some checkouts and not others, on master (d72547f) as well as on branches, so the noise attaches itself to whichever diff is open at the time. Goran hit it reviewing #316; this checkout is clean at rustfmt 1.8.0-stable (rustc 1.94.1).
Add a rust-toolchain.toml pinning channel with the rustfmt and clippy components, then reformat once so the tree is clean under the pinned version.
There is no
rust-toolchain.tomlin the repo, and CI installsdtolnay/rust-toolchain@stable(.github/workflows/build.yml:177), so every checkout formats with whatever stable it happens to have.It already bites:
cargo fmt --checkflagslnvps_api_common/src/exchange.rs:621on some checkouts and not others, on master (d72547f) as well as on branches, so the noise attaches itself to whichever diff is open at the time. Goran hit it reviewing #316; this checkout is clean at rustfmt 1.8.0-stable (rustc 1.94.1).Add a
rust-toolchain.tomlpinningchannelwith therustfmtandclippycomponents, then reformat once so the tree is clean under the pinned version.