Skip to content

ci: upload impacted PR packages and link safe downloads - #16

Open
aaronpowell wants to merge 2 commits into
cicd/registry-routingfrom
cicd/pr-package-artifacts
Open

aaronpowell wants to merge 2 commits into
cicd/registry-routingfrom
cicd/pr-package-artifacts

Conversation

@aaronpowell

@aaronpowell aaronpowell commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Top layer of the CI/CD simplification stack, based on #15 (foundation: #14).

  • Compute impacted plugins from exact base/head merge-base diffs. Shared/unknown changes select all components; component changes select their owner; root docs/skills-only changes skip packaging. Main pushes still validate all plugins.
  • Upload each validated PR .nupkg, checksum and manifest as a seven-day Actions artifact, with direct job-summary downloads. No feeds or releases are published and component versions remain unchanged.
  • Post/update one download comment through a separate workflow_run workflow. Its write-token job loads only its own trusted workflow commit, never PR code or artifact contents. It validates current PR SHA/branch/repository, resolves fork runs without PR metadata, excludes old attempts and reports comment permission failures with summary fallback links.
  • Add actual-git-diff selection regressions (including cross-component renames), 17 mocked comment/trust-boundary tests and download/security documentation.

Validation and rollout

All three PRs pass hosted CI. This layer's successful CI run and four package downloads are available now. Downloaded all four hosted artifacts and verified their exact three-file shape, package metadata, checksums, manifests and clean source state. A read-only dry run against real GitHub run/PR/artifact metadata correctly resolved this PR and generated all four download links without posting a comment.

All repository/release/impact scripts, 17 Node tests and actionlint pass locally. All four components passed Release validation, package inventory and loader checks in this stack; Launcher.MQTT also passed pinned-host and HA template checks. Live GUI/HA installation was not exercised. Hosted CI exposed an expected-failure Git test leaking its native exit code; the follow-up commit restores it and the corrected hosted run passes.

Automatic comments require this separate workflow to exist on the default branch first. This PR's downloadable packages are available from the linked CI run's artifacts/job summaries; automatic workflow_run delivery cannot activate before merge. Fork runs may need maintainer approval, and comments require Actions pull-requests: write. A denied comment is warned explicitly; artifact downloads remain available. No PAT or repository secret is used by PR builds/comments.


Stack created with GitHub Stacks CLI

aaronpowell and others added 2 commits November 20, 2026 14:16
Select components conservatively from merge-base diffs, upload checked NuGet bytes with checksums and manifests, and comment through a trusted workflow_run job without reading PR artifacts.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@aaronpowell
aaronpowell force-pushed the cicd/pr-package-artifacts branch from 1c74cef to 2c2b2ff Compare November 20, 2026 03:17
@aaronpowell
aaronpowell marked this pull request as ready for review November 20, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant